Re: [PATCH] nvme: simplify request ready check for pci

[Christoph Hellwig <hch@lst.de>]

On Mon, Mar 10, 2025 at 09:01:55AM -0600, Keith Busch wrote:
> On Mon, Mar 10, 2025 at 02:24:48PM +0100, Christoph Hellwig wrote:
> > On Fri, Mar 07, 2025 at 03:26:55PM -0800, Keith Busch wrote:
> > > From: Keith Busch <kbusch@kernel.org>
> > > 
> > > The criteria for pci transports' request ready check is simpler than
> > > fabrics. Move the pci check to a different function. This also makes the
> > > existing ready check simpler since it doesn't need to repeatedly test if
> > > the controller is a fabrics type.
> > 
> > The change looks good, but now that this is split, the PCI version
> > should move to pci.c, and the fabrics version should move to fabrics.c
> > and into the nvmf_* namespace.
> 
> I don't think we can move it to pci.c. The apple device isn't fabrics
> either, but is built without the pci.c module, so needs to be in a
> header or common core.

Indeed, Apple messes this up a bit.  But that also means the _pci namespace
is wrong.  It's about all memory transport including the (unspecified)
apple one.  So either rename it to something reflecting that, or just
duplicate it in apple.c as we'd done with a few similar things.