From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6442DC369D7 for ; Tue, 22 Apr 2025 14:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hYlGbAf0RGey9RFXPCMsCmrXYb553xfhYApUNZh+0vQ=; b=SKs+/HBf2xJPr3Qv9l6XKg6I1f 8y+69a+kxyPi7XKeZEEXdeiuWHF4QnnY9hicY1/i8XOoaelcryQFSun4xViZSHwO1Njw6/R1Akwq/ 1jhedaH4vJaxMkT970concgYP1Ki1gtIJEWw9VGLerzB9seUtdSSVfzMELo+skvSSFia7yHe7V+OA 7RCTu+wfNO47Fo1DEKu0hV3P+dip07j0aHchnY1moxIYClDpfg535rPzsTUZ7NOUpLlYXrXAY1vOv dfLpGjHZjsRdnL47E7rLku/+EFJMfraCWh/BEPi9mKIMlrwZhDIIn15YGLLAP3oNOdyc99ehH4Ft8 EpRa6S5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7EjD-00000007Wca-21dM; Tue, 22 Apr 2025 14:36:03 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u787J-000000068H0-1YXx for linux-nvme@lists.infradead.org; Tue, 22 Apr 2025 07:32:31 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0CE9D68AA6; Tue, 22 Apr 2025 09:32:22 +0200 (CEST) Date: Tue, 22 Apr 2025 09:32:21 +0200 From: Christoph Hellwig To: Leon Romanovsky Cc: Christoph Hellwig , Marek Szyprowski , Jens Axboe , Keith Busch , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v8 23/24] nvme-pci: convert to blk_rq_dma_map Message-ID: <20250422073221.GA31688@lst.de> References: <20250422050050.GB28077@lst.de> <20250422072606.GC48485@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250422072606.GC48485@unreal> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250422_003229_695095_69741DEC X-CRM114-Status: GOOD ( 32.24 ) X-Mailman-Approved-At: Tue, 22 Apr 2025 07:26:59 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Apr 22, 2025 at 10:26:06AM +0300, Leon Romanovsky wrote: > On Tue, Apr 22, 2025 at 07:00:50AM +0200, Christoph Hellwig wrote: > > > + dma_len = min_t(u32, length, NVME_CTRL_PAGE_SIZE - (dma_addr & (NVME_CTRL_PAGE_SIZE - 1))); > > > > And overly long line slipped in here during one of the rebases. > > > > > + /* > > > + * We are in this mode as IOVA path wasn't taken and DMA length > > > + * is morethan two sectors. In such case, mapping was perfoormed > > > + * per-NVME_CTRL_PAGE_SIZE, so unmap accordingly. > > > + */ > > > > Where does this comment come from? Lots of spelling errors, and I > > also don't understand what it is talking about as setors are entirely > > irrelevant here. > > I'm trying to say when this do {} while is taken and sector is a wrong > word to describe NVME_CTRL_PAGE_SIZE. Let's remove this comment. Yes, I'd say drop it. > > With the addition of metadata SGL support this also needs to check > > NVME_CMD_SGL_METASEG. > > > > The commit message should also really mentioned that someone > > significantly altered the patch for merging with latest upstream, > > as I as the nominal author can't recognize some of that code. > > Someone :), I thought that adding my SOB is enough. Well, it also has Chaitanya's, so it must have passed through both of you at least. Usually you want to add a little line explaining what you changed for non-trivial changes when changing it. > if (!blk_rq_dma_unmap(req, dev->dev, &iod->dma_meta_state, > iod->total_meta_len)) { > - if (entries == 1) { > + if (iod->cmd.common.flags & NVME_CMD_SGL_METASEG) { > + unsigned int i; > + > + for (i = 0; i < entries; i++) > + dma_unmap_page(dev->dev, > + le64_to_cpu(sg_list[i].addr), > + le32_to_cpu(sg_list[i].length), dir); > + } else { > dma_unmap_page(dev->dev, iod->meta_dma, > - rq_integrity_vec(req).bv_len, > - rq_dma_dir(req)); > + rq_integrity_vec(req).bv_len, dir); > return; It would be nice if we could share a bit of code with the data mapping, but I'm not sure that's possible. I'll try to look into it and review things more carefully once I've reduced my backlog.