From: Christoph Hellwig <hch@lst.de>
To: Richard Weinberger <richard@sigma-star.at>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
kch@nvidia.com, sagi@grimberg.me, hch@lst.de,
upstream+nvme@sigma-star.at, Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [RFC PATCH] nvmet: Make blksize_shift configurable
Date: Tue, 22 Apr 2025 10:16:44 +0200 [thread overview]
Message-ID: <20250422081644.GB411@lst.de> (raw)
In-Reply-To: <8418057.aG60p0z9Xu@anvil>
On Fri, Apr 18, 2025 at 11:56:30AM +0200, Richard Weinberger wrote:
> TBH, I'm not sure whether it makes actually sense for the bdev case to make
> blksize_shift configurable.
> It's also worth discussing whether we should limit blksize_shift to a specific
> range. Right now, any shift is accepted, and it is up to the user to
> use a sane value.
It should have a hard lower bound of 512 bytes (9) and for direct I/O and
the bdev backend the reported dio alignment.
The upper bound is capped by the nvme_lbaf field being a 8-bit value on
the wire, no real need to require anything lower than that probably.
next prev parent reply other threads:[~2025-04-22 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 9:08 [RFC PATCH] nvmet: Make blksize_shift configurable Richard Weinberger
2025-04-18 9:37 ` Damien Le Moal
2025-04-18 9:56 ` Richard Weinberger
2025-04-18 10:23 ` Damien Le Moal
2025-04-18 10:53 ` Richard Weinberger
2025-04-22 8:16 ` Christoph Hellwig [this message]
2025-04-22 6:47 ` Chaitanya Kulkarni
2025-04-22 6:50 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422081644.GB411@lst.de \
--to=hch@lst.de \
--cc=dlemoal@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=richard@nod.at \
--cc=richard@sigma-star.at \
--cc=sagi@grimberg.me \
--cc=upstream+nvme@sigma-star.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox