public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, Hannes Reinecke <hare@kernel.org>
Subject: [PATCHv3 0/2] nvme: restrict authentication to the admin queue
Date: Tue, 22 Apr 2025 11:15:54 +0200	[thread overview]
Message-ID: <20250422091556.145494-1-hare@kernel.org> (raw)

Hi all,

with secure concatenation the spec got more explicit to state that it
would be perfectly fine to implement authentication on the admin queue only.
But once a partner implemented that he found that re-authentication was
failing as we continue to start authentication on all queues.
So these two patches implement this functionalify, the first one to
modify the target to request authentication on the admin queue only,
and the second one to the host to not start authentication on I/O
queues during re-authentication if it wasn't requested initially.

As usual, comments and reviews are welcome.

Changes to the original submission:
- Rebased to nvme-6.14

Changes to v2:
- Include reviews from Sagi
- Drop the configfs attribute

Hannes Reinecke (2):
  nvmet: Authenticate on admin queue only
  nvme: Do not re-authenticate queues with no prior authentication

 drivers/nvme/host/auth.c          | 30 ++++++++++++++++++++++--------
 drivers/nvme/target/auth.c        |  9 ++++++---
 drivers/nvme/target/fabrics-cmd.c |  4 ++--
 3 files changed, 30 insertions(+), 13 deletions(-)

-- 
2.35.3



             reply	other threads:[~2025-04-22 10:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22  9:15 Hannes Reinecke [this message]
2025-04-22  9:15 ` [PATCH 1/2] nvmet: Authenticate on admin queue only Hannes Reinecke
2025-04-25 21:37   ` Sagi Grimberg
2025-04-22  9:15 ` [PATCH 2/2] nvme: Do not re-authenticate queues with no prior authentication Hannes Reinecke
2025-05-07  7:11 ` [PATCHv3 0/2] nvme: restrict authentication to the admin queue Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422091556.145494-1-hare@kernel.org \
    --to=hare@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox