From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Kamaljit Singh <kamaljit.singh@wdc.com>,
Hannes Reinecke <hare@kernel.org>
Subject: [PATCHv4 0/2] nvme-tcp: fixup I/O stall on congested sockets
Date: Mon, 28 Apr 2025 08:50:38 +0200 [thread overview]
Message-ID: <20250428065040.32663-1-hare@kernel.org> (raw)
Hi all,
I have been chasing keep-alive timeouts with TLS enabled in the last few
weeks (months, even ...). On larger setups (eg with 32 queues) the connection
never got established properly as I've been hitting keep-alive timeouts before
the last queue got connected.
Turns out that occasionally we simply do not send the keep-alive request; it's
been added to the request list but the io_work workqueue function is never
restarted as it bails out after nvme_tcp_try_recv() returns -EAGAIN.
During debugging I also found that we're quite lazy with the list
handling of requests, so I've added a patche to ensure that all list
elements are properly terminated.
As usual, comments and reviews are welcome.
Changes to v3:
- Drop first patch as it already had been applied
- Include reviews from Sagi
- Check for sk_sock_is_writeable() to avoid requeing io_work when
the socket is blocked
Changes to v2:
- Removed AEN patches again
Changes to the original submission:
- Include reviews from Chris Leech
- Add patch to requeue namespace scan
- Add patch to re-read ANA log page
Hannes Reinecke (2):
nvme-tcp: sanitize request list handling
nvme-tcp: fix I/O stalls on congested sockets
drivers/nvme/host/tcp.c | 26 +++++++++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
--
2.35.3
next reply other threads:[~2025-04-28 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 6:50 Hannes Reinecke [this message]
2025-04-28 6:50 ` [PATCH 1/2] nvme-tcp: sanitize request list handling Hannes Reinecke
2025-04-28 11:24 ` Sagi Grimberg
2025-04-28 6:50 ` [PATCH 2/2] nvme-tcp: fix I/O stalls on congested sockets Hannes Reinecke
2025-04-28 11:24 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428065040.32663-1-hare@kernel.org \
--to=hare@kernel.org \
--cc=hch@lst.de \
--cc=kamaljit.singh@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox