Re: [PATCH v3 2/2] nvme: all namespaces in a subsystem must adhere to a common atomic write size

[Christoph Hellwig <hch@lst.de>]

On Tue, May 13, 2025 at 10:45:33AM +0100, John Garry wrote:
>> +		 * Set subsystem atomic bs.
>> +		 */
>> +		if (ns->ctrl->subsys->atomic_bs) {
>> +			if (atomic_bs > ns->ctrl->subsys->atomic_bs) {
>
> I am not sure why use > and not !=
>
>> +				pr_err_ratelimited(
>
> could dev_err() be used?

Yes and yes.

>
> "%s: Inconsistent Atomic Write Size,
>
> we could mention that this is the powerfail atomic size, and not "normal". 
> But I suppose that we don't use "normal" values anywhere, so it could be 
> assumed.

I'll keep it as-is, the message is already borderling too long as is.

>> --- a/drivers/nvme/host/nvme.h
>> +++ b/drivers/nvme/host/nvme.h
>> @@ -410,6 +410,7 @@ struct nvme_ctrl {
>>     	enum nvme_ctrl_type cntrltype;
>>   	enum nvme_dctype dctype;
>> +	u16 awupf;
>
> was it intentional to lose the " 0's based awupf value" comment?

I'll add it back.

Can I get a formal review tag after this?