From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, hare@suse.de,
kbusch@kernel.org, sagi@grimberg.me, jmeneghi@redhat.com,
axboe@kernel.dk, martin.petersen@oracle.com, gjoyce@ibm.com
Subject: Re: [RFC PATCHv4 2/3] nvme: introduce multipath_always_on module param
Date: Wed, 14 May 2025 07:42:28 +0200 [thread overview]
Message-ID: <20250514054228.GB24939@lst.de> (raw)
In-Reply-To: <20250509175158.2753396-3-nilay@linux.ibm.com>
I just applied this locally, but ran into somethig that I think is
not addressed here. NVMe allows private namespaces to have non-unіque
nsids if certain features (like ANA) are not enabled. I don't think
we handle this here, and in fact we can't really support that with
the multipath node. But we'll at least need to reject that case
gracefully somehow and document it.
next prev parent reply other threads:[~2025-05-14 5:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 17:51 [RFC PATCHv4 0/3] improve NVMe multipath handling Nilay Shroff
2025-05-09 17:51 ` [RFC PATCHv4 1/3] nvme-multipath: introduce delayed removal of the multipath head node Nilay Shroff
2025-05-12 5:51 ` Hannes Reinecke
2025-05-09 17:51 ` [RFC PATCHv4 2/3] nvme: introduce multipath_always_on module param Nilay Shroff
2025-05-14 5:42 ` Christoph Hellwig [this message]
2025-05-14 13:03 ` Nilay Shroff
2025-05-09 17:51 ` [RFC PATCHv4 3/3] nvme: rename nvme_mpath_shutdown_disk to nvme_mpath_remove_disk Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514054228.GB24939@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox