Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Shminderjit Singh <shminderjit.singh@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"axboe@fb.com" <axboe@fb.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Junxiao Bi <junxiao.bi@oracle.com>
Subject: Re: [PATCH 1/1] nvme-pci: Add quirk for Samsung PM173X with Subsystem Vendor id:0x108e
Date: Fri, 16 May 2025 09:15:41 +0200	[thread overview]
Message-ID: <20250516071541.GA15458@lst.de> (raw)
In-Reply-To: <CO1PR10MB550564E355727779E441B7558393A@CO1PR10MB5505.namprd10.prod.outlook.com>

On Fri, May 16, 2025 at 07:13:47AM +0000, Shminderjit Singh wrote:
> Hi Christoph,
> 
> This device is widely used both within and outside the organization. Applying a firmware fix is not viable option. Since this is firmware specific bug, I am adding a flag for OEM specific devices only.

The general rule is that for enterprise devices we expect you to fix
firmware bugs in firmware.  And skipping all IDs suddently for an
old device also seems like a really odd bug report that you did not
even manage to explain.  



  reply	other threads:[~2025-05-16  7:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16  6:30 [PATCH 0/1] Add quirk for Samsung PM173X with Subsystem Vendor Shminderjit Singh
2025-05-16  6:30 ` [PATCH 1/1] nvme-pci: Add quirk for Samsung PM173X with Subsystem Vendor id:0x108e Shminderjit Singh
2025-05-16  6:36   ` Christoph Hellwig
2025-05-16  7:13     ` Shminderjit Singh
2025-05-16  7:15       ` Christoph Hellwig [this message]
2025-05-16  8:13         ` [External] : " Shminderjit Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250516071541.GA15458@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=junxiao.bi@oracle.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=shminderjit.singh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox