From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FE10C54FC6 for ; Mon, 26 May 2025 05:36:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hlup1PjqSfKGkJisi3U7ttBYekDYvk87YTbtPKExEKw=; b=ggmFK8ISGkt0xipXbUmo2Gafvd 4b3TxKuruKr2hEfPJK6L3gTHiCvS+Mlq+6c16gHS+Xu62vm2u4k2T7MZ09YzTONRwjemhfEb9DAMr Jd9Tav1ak9DFR2Qo3hzocNoLtG/B+ua10ZA7zJI+HeXzuHIO01Zpodq+r+8i4jlQNaIgeyt885s4u sw+0VpXFXnmEt94Qw+t0etBCAv35Vr3rQiQ4x8rwYsfDZ9Ev4vIj0Q/X2EfRnn5CwbfmzUC7EBK2K 3JTTRSY3wLpdvMiYTIj+fGHNr1WI6twV3FEVJ71iRl2bp4O7uXd0sjNqYKdPYb2JS1Dv4K8I8nwRy +OxeWS5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJQVI-0000000880I-2VtJ; Mon, 26 May 2025 05:36:04 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJQVF-000000087yw-3Ydo for linux-nvme@lists.infradead.org; Mon, 26 May 2025 05:36:03 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 8700268AFE; Mon, 26 May 2025 07:35:56 +0200 (CEST) Date: Mon, 26 May 2025 07:35:55 +0200 From: Christoph Hellwig To: Kuniyuki Iwashima Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , Simon Horman , Kuniyuki Iwashima , Chuck Lever , Jeff Layton , Matthieu Baerts , Keith Busch , Jens Axboe , Christoph Hellwig , Wenjia Zhang , Jan Karcher , Steve French , netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v2 net-next 6/7] socket: Replace most sock_create() calls with sock_create_kern(). Message-ID: <20250526053555.GG11639@lst.de> References: <20250523182128.59346-1-kuniyu@amazon.com> <20250523182128.59346-7-kuniyu@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250523182128.59346-7-kuniyu@amazon.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250525_223602_025591_7CFFD27B X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, May 23, 2025 at 11:21:12AM -0700, Kuniyuki Iwashima wrote: > Except for only one user, sctp_do_peeloff(), all sockets created > by drivers and fs are not tied to userspace processes nor exposed > via file descriptors. > > Let's use sock_create_kern() for such in-kernel use cases as CIFS > client and NFS. So if sock_create is now almost unused and the special case, should it also be renamed to make that explicit and make people not accidentally use it by default?