linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Yi Zhang <yi.zhang@redhat.com>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
	Jens Axboe <axboe@fb.com>, Alan Adamson <alan.adamson@oracle.com>
Subject: Re: [bug report]BUG: workqueue leaked atomic, lock or RCU: kworker/u67:3[365] observed from v6.15-rc7
Date: Mon, 2 Jun 2025 07:52:58 +0200	[thread overview]
Message-ID: <20250602055258.GA22318@lst.de> (raw)
In-Reply-To: <CAHj4cs93WutyoPLFMr0JidHhRAxHC1ZDcj-RvdnX=R7OaV5ejg@mail.gmail.com>

On Thu, May 29, 2025 at 08:41:36PM +0800, Yi Zhang wrote:
> Hi
> 
> My regression test found this issue from v6.15-rc7, please help check
> it and let me know if you need any infor/test for it, thanks.

Hi Zi,

The new code seems to be missing a queue_limits_cancel_update,
the patch below fies it.  But what kind of devices is this?
PCIe muti-controller subsystems aren't that command, and this
looks like a grave bug, combined with the I/O page fault that
looks really odd.

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index f69a232a000a..4bb3c68b3451 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2388,6 +2388,7 @@ static int nvme_update_ns_info_block(struct nvme_ns *ns,
 	 * atomic write capabilities.
 	 */
 	if (lim.atomic_write_hw_max > ns->ctrl->subsys->atomic_bs) {
+		queue_limits_cancel_update(ns->disk->queue);
 		blk_mq_unfreeze_queue(ns->disk->queue, memflags);
 		ret = -ENXIO;
 		goto out;


  reply	other threads:[~2025-06-02  5:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 12:41 [bug report]BUG: workqueue leaked atomic, lock or RCU: kworker/u67:3[365] observed from v6.15-rc7 Yi Zhang
2025-06-02  5:52 ` Christoph Hellwig [this message]
2025-06-02  7:51   ` John Garry
     [not found]     ` <CAHj4cs9MxW96b=a6sQOtz_DDc63uKcNX3dat-th__9D0bwRQ9g@mail.gmail.com>
2025-06-11  2:06       ` Yi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250602055258.GA22318@lst.de \
    --to=hch@lst.de \
    --cc=alan.adamson@oracle.com \
    --cc=axboe@fb.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).