From: Christoph Hellwig <hch@lst.de>
To: alan.adamson@oracle.com
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Yi Zhang <yi.zhang@redhat.com>,
John Garry <john.g.garry@oracle.com>
Subject: Re: fix atomic limits check
Date: Mon, 16 Jun 2025 07:36:27 +0200 [thread overview]
Message-ID: <20250616053627.GF1148@lst.de> (raw)
In-Reply-To: <99248994-4d8d-4d84-9279-b657d6969aa0@oracle.com>
On Fri, Jun 13, 2025 at 02:22:00PM -0700, alan.adamson@oracle.com wrote:
> Some testing with my qemu-nvme atomic write setup. My qemu includes ns
> atomic parameters that isn't upstream yet.
> A single subsystem with 4 controllers, 1 of the controllers has 2
> namespaces.
.. and none of the namespaces are shared if I parse the command line
right?
> Does this look right?
I think it does, at least if I understand the setup correctly.
> Before, we had a single atomic_write_max_bytes value per subsystem.
> That's not the case now.
Yes, with AWUPF the value should be different for namespaces with
different LBA sizes, and with NAWUPF it could be different per namespaces.
Maybe we want an extra sanity check to catch a subsystem reporting
differnet NAWUPF for the same namespace attached to multiple controllers,
even if that's against the spec.
And I wonder how we can come up with a testcase to validate all these
checks..
next prev parent reply other threads:[~2025-06-16 5:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 5:54 fix atomic limits check Christoph Hellwig
2025-06-11 5:54 ` [PATCH 1/2] nvme: refactor the atomic write unit detection Christoph Hellwig
2025-06-13 7:52 ` John Garry
2025-06-11 5:54 ` [PATCH 2/2] nvme: fix atomic write boundary validation Christoph Hellwig
2025-06-13 3:04 ` Yi Zhang
2025-06-13 8:03 ` John Garry
2025-06-16 5:31 ` Christoph Hellwig
2025-06-16 7:42 ` John Garry
2025-06-16 11:36 ` Christoph Hellwig
2025-06-16 10:19 ` John Garry
2025-06-16 11:37 ` Christoph Hellwig
2025-06-16 11:49 ` John Garry
2025-06-17 7:36 ` John Garry
2025-06-13 21:22 ` fix atomic limits check alan.adamson
2025-06-16 5:36 ` Christoph Hellwig [this message]
2025-06-17 17:40 ` alan.adamson
2025-06-18 5:32 ` Christoph Hellwig
2025-06-18 16:07 ` alan.adamson
[not found] ` <20250618171750.GA29321@lst.de>
2025-06-18 18:30 ` alan.adamson
2025-06-23 13:33 ` Christoph Hellwig
2025-06-23 17:24 ` alan.adamson
2025-06-24 13:10 ` Christoph Hellwig
2025-06-24 16:38 ` alan.adamson
2025-06-25 6:39 ` Christoph Hellwig
2025-06-17 4:56 ` Christoph Hellwig
2025-06-17 16:38 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616053627.GF1148@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).