linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bryan Gurney <bgurney@redhat.com>
To: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
	sagi@grimberg.me, axboe@kernel.dk
Cc: james.smart@broadcom.com, dick.kennedy@broadcom.com,
	njavali@marvell.com, linux-scsi@vger.kernel.org, hare@suse.de,
	bgurney@redhat.com, jmeneghi@redhat.com
Subject: [PATCH v8 7/8] nvme: sysfs: emit the marginal path state in show_state()
Date: Wed,  9 Jul 2025 17:19:18 -0400	[thread overview]
Message-ID: <20250709211919.49100-8-bgurney@redhat.com> (raw)
In-Reply-To: <20250709211919.49100-1-bgurney@redhat.com>

If a controller has received a link integrity or congestion event, and
has the NVME_CTRL_MARGINAL flag set, emit "marginal" in the state
instead of "live", to identify the marginal paths.

Co-developed-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Tested-by: Muneendra Kumar <muneendra.kumar@broadcom.com>
Signed-off-by: Bryan Gurney <bgurney@redhat.com>
---
 drivers/nvme/host/sysfs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index 29430949ce2f..4a6135c2f9cb 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -430,7 +430,9 @@ static ssize_t nvme_sysfs_show_state(struct device *dev,
 	};
 
 	if (state < ARRAY_SIZE(state_name) && state_name[state])
-		return sysfs_emit(buf, "%s\n", state_name[state]);
+		return sysfs_emit(buf, "%s\n",
+			(nvme_ctrl_is_marginal(ctrl)) ? "marginal" :
+			state_name[state]);
 
 	return sysfs_emit(buf, "unknown state\n");
 }
-- 
2.50.0



  parent reply	other threads:[~2025-07-09 22:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 21:19 [PATCH v8 0/8] nvme-fc: FPIN link integrity handling Bryan Gurney
2025-07-09 21:19 ` [PATCH v8 1/8] fc_els: use 'union fc_tlv_desc' Bryan Gurney
2025-07-09 21:19 ` [PATCH v8 2/8] nvme: add NVME_CTRL_MARGINAL flag Bryan Gurney
2025-07-09 21:19 ` [PATCH v8 3/8] nvme-fc: marginal path handling Bryan Gurney
2025-07-09 21:19 ` [PATCH v8 4/8] nvme-fc: nvme_fc_fpin_rcv() callback Bryan Gurney
2025-07-09 21:19 ` [PATCH v8 5/8] lpfc: enable FPIN notification for NVMe Bryan Gurney
2025-07-09 21:19 ` [PATCH v8 6/8] qla2xxx: " Bryan Gurney
2025-07-09 22:01   ` John Meneghini
2025-07-09 21:19 ` Bryan Gurney [this message]
2025-07-09 22:12   ` [PATCH v8 7/8] nvme: sysfs: emit the marginal path state in show_state() Keith Busch
2025-07-15 19:42     ` John Meneghini
2025-07-15 20:03       ` Keith Busch
2025-07-16  6:07         ` Hannes Reinecke
2025-07-22  2:57           ` Keith Busch
2025-07-22  6:41             ` Hannes Reinecke
2025-07-23 16:58               ` John Meneghini
2025-07-09 22:05 ` [PATCH v8 0/8] nvme-fc: FPIN link integrity handling John Meneghini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250709211919.49100-8-bgurney@redhat.com \
    --to=bgurney@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dick.kennedy@broadcom.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=jmeneghi@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=njavali@marvell.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).