From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C59C2C87FC9 for ; Tue, 29 Jul 2025 14:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mQwwX2iYCrJggUPTGK2S1iJAJ6OSGob73egHYy2twlU=; b=t63spOyOx7mwpfMtJ5CR3g2cTk r+jsOiZAADa6D3RWfMaoZtdFS9eTWA+Vy0PaPnp1928FT3tJFWNgwNSk5CriNhmLnIft5r2eP6J3j BkzGSnMKbtWkcvuBYBXSFTLyY2SyfIBhbafzWd1V5Vm+Bca1qrNTs2GkN5sVWKtgaTc5ftLQ/1PHD 8krft+o1kUIeDeML166TVTevJN81kaPPdcxIQoVVzgH0Bd5X2XJ9hxaSbFzca0M/LrD0IxX3UEMWp Jf1a8NdV1sgmNgKEbZ/4aghDEsjy3ehakqAiyGd9LqlNdy9Xhr8MpGM8LYxsDjzR5mLCl4MHBY91Y 5X4YPyaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uglPt-0000000GuWu-2h9v; Tue, 29 Jul 2025 14:34:57 +0000 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uglPr-0000000GuW9-0RkE for linux-nvme@lists.infradead.org; Tue, 29 Jul 2025 14:34:56 +0000 Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56T6iQIj002625 for ; Tue, 29 Jul 2025 07:34:54 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=s2048-2025-q2; bh=mQwwX2iYCrJggUPTGK2S1iJAJ6OSGob73egHYy2twlU=; b=VzW2Jihem9/N 9KzsUoyuCjdqm0gbkv+z0kulHWmWjC0HFo5hMJDCzFkizjN8zI2/sYpOuwnEC/Ke qIPYX5/MH85eicMnwc7Hza+UkhkWtYBzD4sDWe4mmR8pUtfpzUo7NULlTQf3EY9Y SU9lp6wCoa4DpGZDzrRF7+dv2Vurl+vKAhK6ihaxo/qa6LtmrHWJ1WNzea7JiKI4 BWAE9qmmwZ+89grC5ACmrXa320nViW7b0M7KpY23XkE+rRPyjQi8n7+hE0Gi/YHG 6/4QYIsjfCav0HSmdhrzNoV4Lr6ZaonDIXCCDVxbIM8IAf1879tLbtUujAD7EzFc B8UiLBVPdg== Received: from mail.thefacebook.com ([163.114.134.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 486s9sjg9a-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 29 Jul 2025 07:34:54 -0700 (PDT) Received: from twshared38339.29.prn2.facebook.com (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c08b:78::c78f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Tue, 29 Jul 2025 14:34:53 +0000 Received: by devbig1708.prn1.facebook.com (Postfix, from userid 544533) id 682FF1CC4206; Tue, 29 Jul 2025 07:34:46 -0700 (PDT) From: Keith Busch To: , , CC: , , Keith Busch Subject: [PATCHv3 4/7] blk-mq: remove REQ_P2PDMA flag Date: Tue, 29 Jul 2025 07:34:39 -0700 Message-ID: <20250729143442.2586575-5-kbusch@meta.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250729143442.2586575-1-kbusch@meta.com> References: <20250729143442.2586575-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI5MDExMiBTYWx0ZWRfX+gxscWObhTGF iokqBA+aSgIhWWEL/neqBtcHxc1tznF4Mc4o1Ll3XHyhIieEBh4Cdqn6CU/tXIsk6LEeyjSa1bz QZMA+9XnnYFAYcm+f44oypjowQ8k7EThR/VwqN0yh5etBdf5iAS54Xdv4qxqTJew8j9YRbswEdz qb5pnivknRdeEXbwDqsoE7JoLPf7qHEHeurWsK3NdwCc3pCciIex1EEAN4x+hjo9D9pAcbzPCMA e7Fh2yeO1RLbW5ELia8tMItIEFhoG1cJ0K8yDgBC7DQymaSG1OOdFi+FcXKQqHm0OYwtZvH24me lrmQ/XG86QzQRmXXVLSdF2Kcu7oTxF+Ez6tnXktUNZUP7NZgTNj5gBFsC+P494lmuyrcqBslqny Gub4A1n/DWB8nytyTTiSta2GZ/dKC5Hp5UhguPnK7BldClWSZOoXEt02q1dLzmXcG9u09R01 X-Proofpoint-ORIG-GUID: t2i0drvjbjo3CVp1bsd3Q5mM7uvlLowI X-Proofpoint-GUID: t2i0drvjbjo3CVp1bsd3Q5mM7uvlLowI X-Authority-Analysis: v=2.4 cv=TZiWtQQh c=1 sm=1 tr=0 ts=6888dc0e cx=c_pps a=CB4LiSf2rd0gKozIdrpkBw==:117 a=CB4LiSf2rd0gKozIdrpkBw==:17 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=gTB_xsApw5YEP2-mlJsA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-29_03,2025-07-28_01,2025-03-28_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250729_073455_147078_599A9B62 X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Keith Busch It's not serving any particular purpose. pci_p2pdma_state() already has all the appropriate checks, so the CONFIG and flag checks are not guarding anything. Signed-off-by: Keith Busch --- block/bio.c | 2 +- block/blk-mq-dma.c | 30 ++++++++++++++---------------- include/linux/blk_types.h | 1 - 3 files changed, 15 insertions(+), 18 deletions(-) diff --git a/block/bio.c b/block/bio.c index 92c512e876c8d..f56d285e6958e 100644 --- a/block/bio.c +++ b/block/bio.c @@ -981,7 +981,7 @@ void __bio_add_page(struct bio *bio, struct page *pag= e, WARN_ON_ONCE(bio_full(bio, len)); =20 if (is_pci_p2pdma_page(page)) - bio->bi_opf |=3D REQ_P2PDMA | REQ_NOMERGE; + bio->bi_opf |=3D REQ_NOMERGE; =20 bvec_set_page(&bio->bi_io_vec[bio->bi_vcnt], page, len, off); bio->bi_iter.bi_size +=3D len; diff --git a/block/blk-mq-dma.c b/block/blk-mq-dma.c index 08ce66175a7a3..87c9a7bfa090d 100644 --- a/block/blk-mq-dma.c +++ b/block/blk-mq-dma.c @@ -158,22 +158,20 @@ bool blk_rq_dma_map_iter_start(struct request *req,= struct device *dma_dev, if (!blk_map_iter_next(req, map_iter)) return false; =20 - if (IS_ENABLED(CONFIG_PCI_P2PDMA) && (req->cmd_flags & REQ_P2PDMA)) { - switch (pci_p2pdma_state(&iter->p2pdma, dma_dev, - phys_to_page(map_iter->paddr))) { - case PCI_P2PDMA_MAP_BUS_ADDR: - return blk_dma_map_bus(iter); - case PCI_P2PDMA_MAP_THRU_HOST_BRIDGE: - /* - * P2P transfers through the host bridge are treated the - * same as non-P2P transfers below and during unmap. - */ - req->cmd_flags &=3D ~REQ_P2PDMA; - break; - default: - iter->status =3D BLK_STS_INVAL; - return false; - } + switch (pci_p2pdma_state(&iter->p2pdma, dma_dev, + phys_to_page(map_iter->paddr))) { + case PCI_P2PDMA_MAP_BUS_ADDR: + return blk_dma_map_bus(iter); + case PCI_P2PDMA_MAP_THRU_HOST_BRIDGE: + /* + * P2P transfers through the host bridge are treated the + * same as non-P2P transfers below and during unmap. + */ + case PCI_P2PDMA_MAP_NONE: + break; + default: + iter->status =3D BLK_STS_INVAL; + return false; } =20 if (blk_can_dma_map_iova(req, dma_dev) && diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 09b99d52fd365..0a29b20939d17 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -419,7 +419,6 @@ enum req_flag_bits { #define REQ_DRV (__force blk_opf_t)(1ULL << __REQ_DRV) #define REQ_FS_PRIVATE (__force blk_opf_t)(1ULL << __REQ_FS_PRIVATE) #define REQ_ATOMIC (__force blk_opf_t)(1ULL << __REQ_ATOMIC) -#define REQ_P2PDMA (__force blk_opf_t)(1ULL << __REQ_P2PDMA) =20 #define REQ_NOUNMAP (__force blk_opf_t)(1ULL << __REQ_NOUNMAP) =20 --=20 2.47.3