From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH RFC] nvme-tcp: Implement recvmsg() receive flow
Date: Mon, 22 Sep 2025 19:41:49 +0200 [thread overview]
Message-ID: <20250922174149.GA14736@lst.de> (raw)
In-Reply-To: <20250912115829.58669-1-hare@kernel.org>
On Fri, Sep 12, 2025 at 01:58:29PM +0200, Hannes Reinecke wrote:
> Switch to use recvmsg() so that we get access to TLS control
> messages eg for handling TLS KeyUpdate.
That is a very spare commit message for a huge change. Why did it not
use recvmsg before? I'm pretty sure there are some tradeoffs here.
> +static size_t nvme_tcp_ddgst_step(void *iter_base, size_t progress, size_t len,
> + void *priv, void *priv2)
> +{
> + u32 *crcp = priv;
> +
> + *crcp = crc32c(*crcp, iter_base, len);
> + return 0;
And fix the whitespace damage while you're at it.
next prev parent reply other threads:[~2025-09-22 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 11:58 [PATCH RFC] nvme-tcp: Implement recvmsg() receive flow Hannes Reinecke
2025-09-22 17:41 ` Christoph Hellwig [this message]
2025-09-23 6:30 ` Hannes Reinecke
2026-02-25 10:56 ` Alistair Francis
2026-02-25 11:41 ` Hannes Reinecke
2026-02-25 13:15 ` Alistair Francis
2026-02-25 15:02 ` Hannes Reinecke
2026-02-25 23:37 ` Alistair Francis
2026-02-26 8:40 ` Hannes Reinecke
2026-02-26 10:42 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922174149.GA14736@lst.de \
--to=hch@lst.de \
--cc=alistair.francis@wdc.com \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox