From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCD8ECCD1AB for ; Wed, 22 Oct 2025 10:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=rHDAq7dDwZ+LAzabqu2cFSHYZVRIWSdOvOsOVaMRZfU=; b=UFi1euwdK7x1KK 51Q1hSS3v7CiRafynNkO2k7/VgjhRbwFreKcMPyYMI95DZWscdA/4890xSniveWviHZRR56WliydY yTzJGW9qpFVe8CeRQN1p9zVA1RxJeRt/BwGv35MtpByCbk6pIFqqsU+Z2wzLxYVbLL/T6fHAb+dhg t+H7p4iyfyy3Yj0b13H8oG4DAgfwMptdfYcsCO4uWBZpwUlEXBDt8niSoCXJAeC6OXQepHUbjqgJW xak4yoOvd52VfBdzbNhbuCEoQlIKZbUCZ6Z7/86Tm5Exh45rk+mxjqMx5m8KohFpYZo9iybTpboFA aF1ESii7sWLvnGW3zDjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBWAE-00000002VTM-00Hw; Wed, 22 Oct 2025 10:33:54 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBWA9-00000002VRB-0SQ7 for linux-nvme@lists.infradead.org; Wed, 22 Oct 2025 10:33:51 +0000 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59M7K1XC015478; Wed, 22 Oct 2025 10:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pp1; bh=rHDAq7dDwZ+LAzabqu2cFSHYZVRI WSdOvOsOVaMRZfU=; b=YBqaHqzezIFBkL8OW12F6eJHaNCV6Pveyl5eyeO1laj8 Kw2BPWGLqABR/k9MQxR0bu9MFKld+/3xsrBSKFVCeuqAmLRNO0oQCiLwz4ev8KI4 Lp5sKEHCr4dID2uZpP992TMyZCbl7JZD/hvI+Rj0PP4S+Uey8otQz2gjd6XcBAtS XinXIFW8p/HTX0u5WknUlu8CVgfH4X9nAIVAY2d0RT1cwcbDzUh0Fgx5u5lj4DxW QceXvcixiHZaKqbuzC/nHSG+ZO4S/fDtmCIpP0Ew/5xvM7MdNRA9vGsZcZOTC9E/ KX5IVsyoZWHSYMTt/CiuaWnG1Y3Rqa16wWX1q5akWA== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v30vtqgk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 10:33:47 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59M9XRZ0014663; Wed, 22 Oct 2025 10:33:46 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 49vn7s7ydy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 10:33:46 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59MAXjjf58458470 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Oct 2025 10:33:45 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E5E7B200A5; Wed, 22 Oct 2025 10:33:44 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C0A9B200A4; Wed, 22 Oct 2025 10:33:44 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Oct 2025 10:33:44 +0000 (GMT) From: Gerd Bayer Subject: [PATCH v2 0/2] nvme-pci: Log failures to probe Date: Wed, 22 Oct 2025 12:33:15 +0200 Message-Id: <20251022-nvme_probefail-v2-0-26bbdf94280e@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAOuy+GgC/13Myw6CMBCF4Vchs7ZkWrkIK9/DEFNgkEmgJa02G MK7W4krl/9JzreBJ8fkoU42cBTYszUx1CmBbtTmQYL72KBQ5RJlLkyY6b4429KgeRLnqiykQp2 VsoJ4WhwNvB7grYk9sn9a9z78IL/rj1L4TwUpUOhMIWZFX10GvE5sXmvK7Zx2doZm3/cPOnItD 7AAAAA= X-Change-ID: 20251015-nvme_probefail-3976120a4719 To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Niklas Schnelle , Greg Kroah-Hartman , Chaitanya Kulkarni , Wilfred Mallawa , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Gerd Bayer , Chaitanya Kulkarni X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LhNL_wz_EbG7119_-nPbLDT_CZCp4qzV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfX2prggI4Yh86S rg+zlIYcowWSPKMRB05OGjaHVqrOXjGw9rOlDw493gAaE5QRSDZsHPDrM1HH1zwMgzUTymo/kBq ccScn/2DFkYFg4WzeB1ha+/0mpFjWNCZAH3wfFe1Q+3sADJ+9HXSoS13Ueqro1nkIHCS2VYz8ex W48cZXM/99Y1DqEaYu1RdbDE3UReF3HPwSBk/u22F+KUSZkAuQ66umQ1L8zKJIcbtwbiO4HMsaO yMmy+QGnCSgk4JhYA43G73xb4Edx01PXLJupXFEp1LKH/dgR3uirLNzU3vRzR6ICcEyxFvoz9Il +K7c/a7hhqDMWdxwV/3f8qm4FzeW4OvfvOxKpCwFjMQ5FJ4pTqaUhIxCi3vHp8x7vXN6gEtq0ij GQNehe0kcwGGtYHEvxoA6XyShS35pQ== X-Authority-Analysis: v=2.4 cv=MIJtWcZl c=1 sm=1 tr=0 ts=68f8b30b cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=4PydOPZSPFsZ0nwRxBgA:9 a=QEXdDO2ut3YA:10 a=cPQSjfK2_nFv0Q5t_7PE:22 a=HhbK4dLum7pmb74im6QT:22 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-Proofpoint-ORIG-GUID: LhNL_wz_EbG7119_-nPbLDT_CZCp4qzV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_03,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 impostorscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251022_033349_315158_067590F4 X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi, occasionally, an NVMe drive fails to reply to MMIO reads despite the PCI link being operational. In these situations (obviously not on the boot-device :) it is preferred to have this reported in the kernel log instead of deducing that something is wrong by comparing expectated vs. observed number of nvme devices. - 1/2 adds a clear indication that the device driver failed to probe an NVMe drive and will not register a nvme device. - 2/2 adds a debug log that allows to further zoom in on the exact failure I've split this into two patches, since 2/2 might be less important wrt to back-ports, etc. Thanks, Gerd Signed-off-by: Gerd Bayer --- Changes in v2: - Patch 1/2: - Replace dev_err() with dev_err_probe(), now last before return - Drop R-b from Wilfred Mallawa - Patch 2/2: Reword as suggested by Christoph Hellwig, pick up R-b's - Link to v1: https://lore.kernel.org/r/20251020-nvme_probefail-v1-0-a420046d98f0@linux.ibm.com --- Gerd Bayer (2): nvme-pci: Print error message on failure in nvme_probe nvme-pci: Add debug message on fail to read CSTS drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: 211ddde0823f1442e4ad052a2f30f050145ccada change-id: 20251015-nvme_probefail-3976120a4719 Best regards, -- Gerd Bayer