From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCHv2] nvme-pci: use blk_map_iter for p2p metadata
Date: Wed, 22 Oct 2025 08:00:52 +0200 [thread overview]
Message-ID: <20251022060052.GB4220@lst.de> (raw)
In-Reply-To: <20251021151831.2009152-1-kbusch@meta.com>
On Tue, Oct 21, 2025 at 08:18:31AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The dma_map_bvec helper doesn't work for p2p data, so use the same
> blk_map_iter method that sgl uses for this memory type.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although I'd still rename nvme_pci_setup_meta_sgls as in my draft as
the name is a bit misleading now.
next prev parent reply other threads:[~2025-10-22 6:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 15:18 [PATCHv2] nvme-pci: use blk_map_iter for p2p metadata Keith Busch
2025-10-22 3:18 ` Chaitanya Kulkarni
2025-10-22 6:00 ` Christoph Hellwig [this message]
2025-10-23 2:46 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022060052.GB4220@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=leon@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox