From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C823CCD1AB for ; Fri, 24 Oct 2025 11:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UeCuEQVHAnAaIsPQ3B/TgqZ/BFogCSgrx+enGmZQux4=; b=1iT8fn46+6NGEu wFmKBT4VVmGOUiaR8y3Y2dU9a9Ib6v8cKQ5dsPYb76XTdohNpJT0YQnH92aedVSe1h8XfhnOMNxNr rzoxPrFZ6zVpLeyXUWOVAvxs1d8kvr6/b5hu396HmWWv+1dllNK6X/vsVpYuFBS2uZ56csP5lDyMn nGiVpV41T5lr4Z/lDr9LSLA+Kbmgm2JtCtqyBwn1f32wLD0ZAmj9hisdxvUJ2m6JLYgDnF8tjB6gt bXLpQKJNihEsB8XEuqIDeR50IUmHXWxMOtgPyQeNQD/lyIn6Uj8hZS93wkssCwYa++hLp+tFPtaBH RUgMWIGcKrO+USRsubcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCFch-000000097NE-2lAG; Fri, 24 Oct 2025 11:06:19 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCFce-000000097Mn-382o for linux-nvme@lists.infradead.org; Fri, 24 Oct 2025 11:06:18 +0000 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59NJxlxn004702; Fri, 24 Oct 2025 11:06:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pp1; bh=UeCuEQVHAnAaIsPQ3B/TgqZ/BFog CSgrx+enGmZQux4=; b=Swhj3PpoFveI1UPHj3szZVeLnPNi4tSkVtowA9UoW+45 9qQeaMvgS81g7EndxMUtS3ewQtNvc/kz6eR5JBPwCgfyWuBIsQwuNRrS6ycTHIUm mhbPk4ZxSMtAKdOMDnxv4w/j9KPLm5VPZYPlkZpugLeO9L3DsaAi3Y6lDulmf6t9 tQui9mg2r1SgQB3YXtf/3TrbqoyLRIwzneTaFIks2Z4gycoR3spxz8J/9PdJj43b i7o9S6s7EE/HZg1kL5v9X9i9sMLCOfAVPt9sGy7taWEYdn72d+KgGfDFo1ce+tqe NPwxshHxcnyp54rak7q18fyKkgOWsEM2bTAEmlkflQ== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31cnfaw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Oct 2025 11:06:08 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59O9fnNF032142; Fri, 24 Oct 2025 11:06:08 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 49vp7napec-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Oct 2025 11:06:07 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59OB63Wb61800846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Oct 2025 11:06:03 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C76852004B; Fri, 24 Oct 2025 11:06:03 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 94EE920043; Fri, 24 Oct 2025 11:06:03 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 24 Oct 2025 11:06:03 +0000 (GMT) From: Gerd Bayer Subject: [PATCH v3 0/2] nvme-pci: Log failures to probe Date: Fri, 24 Oct 2025 13:05:30 +0200 Message-Id: <20251024-nvme_probefail-v3-0-5386f905378b@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAHpd+2gC/2XMSwqDMBSF4a1Ixo3cXOOro+6jlGI0qRd8kbTBI u69UToodvgfON/CnLakHTtHC7Pak6NxCJGcIla31fDQnJrQDAFTASLlg+/1fbKj0qaijidlngm ESuaiZOE0WW1o3sHrLXRL7jna9+57sa1fCuFIecGBVxIBZNaUhYFLR8Nrjkn1cT32bOM8/hL4R 2AgMFOqMaXEAvSRWNf1AxBbg+HzAAAA X-Change-ID: 20251015-nvme_probefail-3976120a4719 To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Niklas Schnelle , Greg Kroah-Hartman , Chaitanya Kulkarni , Wilfred Mallawa , John Garry , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Gerd Bayer X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: V8HgxT0Kmk0Hnieurcz85xjnnblC4AIi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfX/IIEL0z107Lw uDogcYas4xbgo1p5Xw1zS+47Gt2AV3AE/ELgJ4K0Chyk3+ZK7kxK/mkPiyzk3rJm3yScdZgFceA bEeC0OzRS44z27+7FqnsIdBKVrwAbisRIexhBvFPvbuMkLxB3UkQBlonQxwwdUSGmOKzkYIX09V VdnTxCo4P4OF8IkFaQLkXP8i82Xu1PON5oXLfz/Ixg3AmG+Eim+6reGckMeyh27xabFxgX7IZqw PSKK6P0oZqqT0elA3nj5ReHNd1vQuY4/PaSl6oSB+6qW7pnQfbKH+KIE4yaUjXm5mHGA5WT8OGt x5dHWXVBvypKZgoEId4VEFTXvAqddqTR+H4EMJLcqYyHaxhkmpA4mZvYkhbRiOneGG4OsemGT1L BWMyupcNb7Ztyt4gMYszxsUKDs/5Kw== X-Proofpoint-GUID: V8HgxT0Kmk0Hnieurcz85xjnnblC4AIi X-Authority-Analysis: v=2.4 cv=SKNPlevH c=1 sm=1 tr=0 ts=68fb5da0 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=4PydOPZSPFsZ0nwRxBgA:9 a=QEXdDO2ut3YA:10 a=HhbK4dLum7pmb74im6QT:22 a=cPQSjfK2_nFv0Q5t_7PE:22 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-24_01,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251024_040616_908427_76EB3CDB X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi, occasionally, an NVMe drive fails to reply to MMIO reads despite the PCI link being operational. In these situations (obviously not on the boot-device :) it is preferred to have this reported in the kernel log instead of deducing that something is wrong by comparing expectated vs. observed number of nvme devices. - 1/2 adds a clear indication that the device driver failed to probe an NVMe drive and will not register a nvme device. - 2/2 adds a debug log that allows to further zoom in on the exact failure I've split this into two patches, since 2/2 might be less important wrt to back-ports, etc. Thanks, Gerd Signed-off-by: Gerd Bayer --- Changes in v3: - Both patches: Added Christop Helwig's R-b's - Patch 2/2: add newline (per John Garry) - Link to v2: https://lore.kernel.org/r/20251022-nvme_probefail-v2-0-26bbdf94280e@linux.ibm.com Changes in v2: - Patch 1/2: - Replace dev_err() with dev_err_probe(), now last before return - Drop R-b from Wilfred Mallawa - Patch 2/2: Reword as suggested by Christoph Hellwig, pick up R-b's - Link to v1: https://lore.kernel.org/r/20251020-nvme_probefail-v1-0-a420046d98f0@linux.ibm.com --- Gerd Bayer (2): nvme-pci: Print error message on failure in nvme_probe nvme-pci: Add debug message on fail to read CSTS drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: 211ddde0823f1442e4ad052a2f30f050145ccada change-id: 20251015-nvme_probefail-3976120a4719 Best regards, -- Gerd Bayer