From: Gerd Bayer <gbayer@linux.ibm.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chaitanya Kulkarni <kch@nvidia.com>,
Wilfred Mallawa <wilfred.mallawa@wdc.com>,
John Garry <john.g.garry@oracle.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Gerd Bayer <gbayer@linux.ibm.com>
Subject: [PATCH v3 1/2] nvme-pci: Print error message on failure in nvme_probe
Date: Fri, 24 Oct 2025 13:05:31 +0200 [thread overview]
Message-ID: <20251024-nvme_probefail-v3-1-5386f905378b@linux.ibm.com> (raw)
In-Reply-To: <20251024-nvme_probefail-v3-0-5386f905378b@linux.ibm.com>
Add a new error message that makes failures to probe visible in the
kernel log, like:
nvme 0008:00:00.0: error -ENODEV: probe failed
This highlights issues with a particular device right away instead of
leaving users to search for missing drives.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
---
drivers/nvme/host/pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c916176bd9f058b49e6e6768675711df52b15765..8c624960c9f67e0cc8409023de5e532d6ed9b3ac 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3522,6 +3522,7 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
nvme_uninit_ctrl(&dev->ctrl);
out_put_ctrl:
nvme_put_ctrl(&dev->ctrl);
+ dev_err_probe(&pdev->dev, result, "probe failed\n");
return result;
}
--
2.48.1
next prev parent reply other threads:[~2025-10-24 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 11:05 [PATCH v3 0/2] nvme-pci: Log failures to probe Gerd Bayer
2025-10-24 11:05 ` Gerd Bayer [this message]
2025-10-26 7:20 ` [PATCH v3 1/2] nvme-pci: Print error message on failure in nvme_probe Wilfred Mallawa
2025-10-24 11:05 ` [PATCH v3 2/2] nvme-pci: Add debug message on fail to read CSTS Gerd Bayer
2025-10-27 16:13 ` [PATCH v3 0/2] nvme-pci: Log failures to probe Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024-nvme_probefail-v3-1-5386f905378b@linux.ibm.com \
--to=gbayer@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=schnelle@linux.ibm.com \
--cc=wilfred.mallawa@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox