* [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline
@ 2025-11-02 3:17 Chaitanya Kulkarni
2025-11-03 11:46 ` Christoph Hellwig
2025-11-03 15:35 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2025-11-02 3:17 UTC (permalink / raw)
To: hare, kbusch; +Cc: hch, linux-nvme, Chaitanya Kulkarni, kernel test robot
Fix build warning when CONFIG_NVME_KEYRING is not enabled:
include/linux/nvme-keyring.h:57:4: warning: no previous prototype for
function 'nvme_dhchap_psk_hash' [-Wmissing-prototypes]
The nvme_dhchap_psk_hash() stub function in the #else block is missing
the 'static inline' qualifiers that all other stub functions in the same
block have. Add them to fix the warning.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202511011103.e6eXLAln-lkp@intel.com/
Fixes: 8d9937531a4d ("nvme-keyring: add 'dhchap' key type")
Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
---
include/linux/nvme-keyring.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nvme-keyring.h b/include/linux/nvme-keyring.h
index 6115bf5cf346..4bdac22b3cbb 100644
--- a/include/linux/nvme-keyring.h
+++ b/include/linux/nvme-keyring.h
@@ -54,7 +54,7 @@ static inline struct key *nvme_dhchap_psk_lookup(struct key *keyring,
{
return ERR_PTR(-ENOTSUPP);
}
-u8 nvme_dhchap_psk_hash(struct key *key)
+static inline u8 nvme_dhchap_psk_hash(struct key *key)
{
return 0;
}
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline
2025-11-02 3:17 [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline Chaitanya Kulkarni
@ 2025-11-03 11:46 ` Christoph Hellwig
2025-11-03 15:35 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2025-11-03 11:46 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: hare, kbusch, hch, linux-nvme, kernel test robot
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline
2025-11-02 3:17 [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline Chaitanya Kulkarni
2025-11-03 11:46 ` Christoph Hellwig
@ 2025-11-03 15:35 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2025-11-03 15:35 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: hare, hch, linux-nvme, kernel test robot
On Sat, Nov 01, 2025 at 08:17:01PM -0700, Chaitanya Kulkarni wrote:
> Fix build warning when CONFIG_NVME_KEYRING is not enabled:
>
> include/linux/nvme-keyring.h:57:4: warning: no previous prototype for
> function 'nvme_dhchap_psk_hash' [-Wmissing-prototypes]
>
> The nvme_dhchap_psk_hash() stub function in the #else block is missing
> the 'static inline' qualifiers that all other stub functions in the same
> block have. Add them to fix the warning.
Thanks, applied to nvme-6.19.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-03 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-02 3:17 [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline Chaitanya Kulkarni
2025-11-03 11:46 ` Christoph Hellwig
2025-11-03 15:35 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox