Re: [PATCH v5 4/6] net/handshake: Support KeyUpdate message types

Hannes Reinecke
2025-11-27T13:12:27Z

On 11/12/25 05:27, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> When reporting the msg-type to userspace let's also support reporting
> KeyUpdate events. This supports reporting a client/server event and if
> the other side requested a KeyUpdateRequest.
>
> Link: https://datatracker.ietf.org/doc/html/rfc8446#section-4.6.3
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> v5:
> - Drop clientkeyupdaterequest and serverkeyupdaterequest
> v4:
> - Don't overload existing functions, instead create new ones
> v3:
> - Fixup yamllint and kernel-doc failures
>
> Documentation/netlink/specs/handshake.yaml | 16 ++++-
> drivers/nvme/host/tcp.c | 15 +++-
> drivers/nvme/target/tcp.c | 10 ++-
> include/net/handshake.h | 6 ++
> include/uapi/linux/handshake.h | 11 +++
> net/handshake/tlshd.c | 83 +++++++++++++++++++++-
> 6 files changed, 133 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich