[PATCH] nvme-auth: Use kvfree() for memory allocated with kvcalloc()

[PATCH] nvme-auth: Use kvfree() for memory allocated with kvcalloc()

[Israel Rukshin]

Memory allocated by kvcalloc() may come from vmalloc or kmalloc,
so use kvfree() instead of kfree() for proper deallocation.

Fixes: aa36d711e945 ("nvme-auth: convert dhchap_auth_list to an array")
Signed-off-by: Israel Rukshin <israelr@nvidia.com>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
 drivers/nvme/host/auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index a01178caf15b..8f3ccb317e4d 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -1122,7 +1122,7 @@ void nvme_auth_free(struct nvme_ctrl *ctrl)
 	if (ctrl->dhchap_ctxs) {
 		for (i = 0; i < ctrl_max_dhchaps(ctrl); i++)
 			nvme_auth_free_dhchap(&ctrl->dhchap_ctxs[i]);
-		kfree(ctrl->dhchap_ctxs);
+		kvfree(ctrl->dhchap_ctxs);
 	}
 	if (ctrl->host_key) {
 		nvme_auth_free_key(ctrl->host_key);
-- 
2.34.1

Re: [PATCH] nvme-auth: Use kvfree() for memory allocated with kvcalloc()

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] nvme-auth: Use kvfree() for memory allocated with kvcalloc()

[Keith Busch]

On Sun, Nov 23, 2025 at 04:46:48PM +0200, Israel Rukshin wrote:
> Memory allocated by kvcalloc() may come from vmalloc or kmalloc,
> so use kvfree() instead of kfree() for proper deallocation.

Thanks, applied to nvme-6.19.

Re: [PATCH] nvme-auth: Use kvfree() for memory allocated with kvcalloc()

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>