From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C56ED0E6C7 for ; Tue, 25 Nov 2025 11:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RvjJCIGAH8efJ+1bSKUR5i0q2+audBBVsge7Vz5c4Us=; b=JS37qTOnNfy05Tto51HYK+f4Ri WXNJ2Apo7Pipfpb55Qm7UYuO8wAbvCOA5nzeLMv/aXQ8NZJ8NKe+WRNlZYFvpfQTz+naUggVkzSaR ESv7tgX/FHPFz8X5s5uL6jhIAWhi7KhPf5L2ayscrEHY7/pQzX/ZmZp9FcpwYI9lqfuxry16YxPAM lwHEF+wQntoyzL58yLAhJY1VnUYVfbCCzlqMN049GF4SSfzUYLwUPWmtNdJl4iZZ1OCPJdkMx5mDA 9jCiKRFcJo971dtiKWSxqd3kTJdG4+jMXpr0W9xAuVKtLo69Kz1xGPGwtE6ymcClq9jCp/goYXTzl lnPQ7mPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNr6l-0000000DCrt-3qTy; Tue, 25 Nov 2025 11:21:19 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNr6h-0000000DCrD-3xN0 for linux-nvme@lists.infradead.org; Tue, 25 Nov 2025 11:21:18 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3BF8468B05; Tue, 25 Nov 2025 12:21:11 +0100 (CET) Date: Tue, 25 Nov 2025 12:21:11 +0100 From: "hch@lst.de" To: Nilay Shroff Cc: Chaitanya Kulkarni , Christoph Hellwig , Chaitanya Kulkarni , "kbusch@kernel.org" , "hch@lst.de" , "hare@suse.de" , "sagi@grimberg.me" , "axboe@kernel.dk" , "dlemoal@kernel.org" , "wagi@kernel.org" , "mpatocka@redhat.com" , "yukuai3@huawei.com" , "xni@redhat.com" , "linan122@huawei.com" , "bmarzins@redhat.com" , "john.g.garry@oracle.com" , "edumazet@google.com" , "ncardwell@google.com" , "kuniyu@google.com" , "davem@davemloft.net" , "dsahern@kernel.org" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "netdev@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" Subject: Re: [RFC blktests fix PATCH] tcp: use GFP_ATOMIC in tcp_disconnect Message-ID: <20251125112111.GA22545@lst.de> References: <20251125061142.18094-1-ckulkarnilinux@gmail.com> <0caa9d00-3f69-4ade-b93b-eea307fe6f72@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0caa9d00-3f69-4ade-b93b-eea307fe6f72@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_032117_353148_40951CFA X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Nov 25, 2025 at 04:43:25PM +0530, Nilay Shroff wrote: > The memalloc_noreclaim_save() above shall already prevent filesystem > reclaim, memalloc_noreclaim_save is oddly misnamed, as it sets the PF_MEMALLOC, which does not cause any gfp_t flag adjustments, but instead avoid direct reclaim. Thinking of it I have no idea why it is even used here.