From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA510D116F1 for ; Mon, 1 Dec 2025 16:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4iWnwLMwmGLsjkBGFc5ezIShODWDymLzptUH0xLu4zU=; b=lcHvQjGqVzbL+IZR+HTraHrgey 1xVjQrbjzcOJBEfwgG9ylvo5bHkqtLPaxDdY5v2f2xvlCtgNjAjcuOt0fzlE33inHaVLpBSNJMG6l Z7vOKCPNJLVSTmWt146LV1oSAtdENOMXPoAWi5s7MZ9flEmO/3uT3YWFyS34vp4r6HdQ0rzHbfaYp 3WYxlpdMr/P0Yui2o5VBC6wQMqsO7Rnj6ppP+Qw4rNSkJrFh+WZ4Wgon90ASXYjbo1YrTYYtUqjGT Laazxab/TCIuQ4+tnXQNEsfR8rDVXvM3tP7Ff8G/H2+AcQ0UUzzvilpwD1aXx8nTbXdk3yAn033NM 0qtgxFsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQ6gX-00000004Fhy-0ki5; Mon, 01 Dec 2025 16:23:33 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQ6gU-00000004FgT-26nT for linux-nvme@lists.infradead.org; Mon, 01 Dec 2025 16:23:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764606209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4iWnwLMwmGLsjkBGFc5ezIShODWDymLzptUH0xLu4zU=; b=dYSAngZzPobW+1LrSViAiFRCiGSeYP/eNKgtukKT2UdkqCWh2IE1ncfGr+c1gN074B1232 IkAK/ima/1QMf92+8xrLIC7VuEFibvv2m1bQuz6JtcP6Rgtv9g4ccxor7jycs6TuuKVoWE aQ0cuNlcmUbIklznzSbVy7GLXMEpwrY= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-YIt7-LwiMqizY8fJDXan2w-1; Mon, 01 Dec 2025 11:23:22 -0500 X-MC-Unique: YIt7-LwiMqizY8fJDXan2w-1 X-Mimecast-MFC-AGG-ID: YIt7-LwiMqizY8fJDXan2w_1764606200 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AEAE41956094; Mon, 1 Dec 2025 16:23:19 +0000 (UTC) Received: from localhost (unknown [10.2.16.172]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8724D1800451; Mon, 1 Dec 2025 16:23:18 +0000 (UTC) Date: Mon, 1 Dec 2025 11:23:17 -0500 From: Stefan Hajnoczi To: Christoph Hellwig Cc: linux-block@vger.kernel.org, Keith Busch , "Martin K. Petersen" , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Mike Christie , linux-nvme@lists.infradead.org, Jens Axboe , linux-scsi@vger.kernel.org, Sagi Grimberg Subject: Re: [PATCH v2 1/4] scsi: sd: reject invalid pr_read_keys() num_keys values Message-ID: <20251201162317.GE866564@fedora> References: <20251127155424.617569-1-stefanha@redhat.com> <20251127155424.617569-2-stefanha@redhat.com> <20251201063413.GA19461@lst.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/q2A/sdcGUHGB5kN" Content-Disposition: inline In-Reply-To: <20251201063413.GA19461@lst.de> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251201_082330_612772_420CB8A7 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org --/q2A/sdcGUHGB5kN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 01, 2025 at 07:34:13AM +0100, Christoph Hellwig wrote: > On Thu, Nov 27, 2025 at 10:54:21AM -0500, Stefan Hajnoczi wrote: > > + /* > > + * Each reservation key takes 8 bytes and there is an 8-byte header > > + * before the reservation key list. The total size must fit into the > > + * 16-bit ALLOCATION LENGTH field. > > + */ > > + if (num_keys > (USHRT_MAX / 8) - 1) > > + return -EINVAL; > > + > > + data_len =3D num_keys * 8 + 8; >=20 > Having the same arithmerics express here in two different ways is a bit > odd. >=20 > I'd expected this to be something like: >=20 > if (check_mul_overflow(num_keys, 8, &data_len) || data_len > USHRT_MAX) > return -EINVAL; Will fix, thanks. Stefan --/q2A/sdcGUHGB5kN Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmktwPUACgkQnKSrs4Gr c8g0gwgAiEUYpY9G7g748zxuE7RRdteHJBtuBVbAtrYXJqfIdAmupy9eKEf9Sa1D FUo7wdk9KaajdFP8aJSFuqdy81X4qMI5wjnl7Yv5mpbCUdVXTrTWQy3yEx93ILlO iCpY+0cdWjCslnFTsIdzawzlo7+4xLEzWcVBG+gRlCd3Z598f8uAyZEXwuc36qwv ki8wRuKkfHzLmF57XTBR/ZhJmSSFzSCFkqOneFoXX8VsDrGF7yOLyyJ0q9ATBJo4 U15dVvLjQd1cYZhHjHX30W4rXLL4UhXWSURGKcrYXlLQW0g7B4JloBMCOFup5U6Y ubAwouirRAk9bodTanTM+CJq/292Pw== =eJaQ -----END PGP SIGNATURE----- --/q2A/sdcGUHGB5kN--