From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D968CFD376 for ; Tue, 2 Dec 2025 06:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M54zR4FXwrxpBPTN1oeAfqmn+yGNPbKqE4DhIIHJj5U=; b=VB2tqOgw2FVobp4YHGG0RuP5mf a1q1nTGODYZ2AepZREVwywDa+m31gzlFmaqReDBfiqHEDUVSzf9/SMfcBmNYrqoaKzWwqwVPmM9Me RN4K0z1pl3aJz9VxsD7tiRxJt4o/oI9TOlkEhLTDCFwVs9UGVmZpcfH/96hMpLzpXsWtMjjXSVxC/ D5bITEWR7l6LfsYsd2w8RA4JfsG4keQwcWQhrx6c4/1FoXIout1U1tFJpXUEmomvVXXYGSOPIGUYB UeLhdAaRW9+5C+8Ztny3fnYXPSW06CcIaaY9cRQrH4q0F7ZJZ9qP1+/rJnnqhT4aBOI+5u2qyliDF 90A1mTNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQJT9-00000004scT-1Wzt; Tue, 02 Dec 2025 06:02:35 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQJT6-00000004sbQ-2GKg for linux-nvme@lists.infradead.org; Tue, 02 Dec 2025 06:02:34 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2C4A868AA6; Tue, 2 Dec 2025 07:02:27 +0100 (CET) Date: Tue, 2 Dec 2025 07:02:26 +0100 From: Christoph Hellwig To: alistair23@gmail.com Cc: chuck.lever@oracle.com, hare@kernel.org, kernel-tls-handshake@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, hare@suse.de, Alistair Francis Subject: Re: [PATCH v6 4/5] nvme-tcp: Support KeyUpdate Message-ID: <20251202060226.GA16055@lst.de> References: <20251202013429.1199659-1-alistair.francis@wdc.com> <20251202013429.1199659-5-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251202013429.1199659-5-alistair.francis@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251201_220232_722394_35AE1ED0 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Dec 02, 2025 at 11:34:28AM +1000, alistair23@gmail.com wrote: > + if (unlikely(ret < 0)) { > + goto msg_control; > } This should drop the superfluous braces. Otherwise looks good: Reviewed-by: Christoph Hellwig