Re: [BUG FIX PATCH COMPILE TESTED ONLY] nvme-fc: release admin tagset if init fails

Justin Tee
2026-01-08T22:51:30Z

> thanks for looking into this, it was observed when Yi reported the issue.
>
> Irrespective of whether it is repro issue, it's still a bug ?
>
> Can you please provide review comments ?

Yes, agreed after reviewing the current goto fail_ctrl path that there
is a missing nvme_remove_admin_tag_set.  I can provide the Reviewed-by
stamp.

I guess I’d prefer if we can prove this resolves the issue Yi reported.
If Yi could re-rerun nvme-fc blktests on the original failing setup with
this patch, that would be great to confirm.

Thanks,
Justin