[PATCH v2] nvme/host: fixup some typos

[PATCH v2] nvme/host: fixup some typos

[Wilfred Mallawa]

From: Wilfred Mallawa <wilfred.mallawa@wdc.com>

Fixup some minor typos in the nvme host drivers.

Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
---
 drivers/nvme/host/ioctl.c | 2 +-
 drivers/nvme/host/tcp.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index a9c097dacad6..62d4bff7ebdd 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -718,7 +718,7 @@ int nvme_ns_head_ioctl(struct block_device *bdev, blk_mode_t mode,
 
 	/*
 	 * Handle ioctls that apply to the controller instead of the namespace
-	 * separately and drop the ns SRCU reference early.  This avoids a
+	 * separately and drop the ns SRCU reference early. This avoids a
 	 * deadlock when deleting namespaces using the passthrough interface.
 	 */
 	if (is_ctrl_ioctl(cmd))
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 69cb04406b47..8d389399187d 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -25,7 +25,7 @@
 
 struct nvme_tcp_queue;
 
-/* Define the socket priority to use for connections were it is desirable
+/* Define the socket priority to use for connections where it is desirable
  * that the NIC consider performing optimized packet processing or filtering.
  * A non-zero value being sufficient to indicate general consideration of any
  * possible optimization.  Making it a module param allows for alternative
@@ -926,7 +926,7 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb,
 			req->curr_bio = req->curr_bio->bi_next;
 
 			/*
-			 * If we don`t have any bios it means that controller
+			 * If we don't have any bios it means that controller
 			 * sent more data than we requested, hence error
 			 */
 			if (!req->curr_bio) {
-- 
2.52.0

Re: [PATCH v2] nvme/host: fixup some typos

[Christoph Hellwig]

Bit: the subject prefix is we usually use is just "nvme: ".

>  	/*
>  	 * Handle ioctls that apply to the controller instead of the namespace
> -	 * separately and drop the ns SRCU reference early.  This avoids a
> +	 * separately and drop the ns SRCU reference early. This avoids a

I don't see a typo here, just a reformatting to a different comment
style not very commonly used in the nvme code.

> -/* Define the socket priority to use for connections were it is desirable
> +/* Define the socket priority to use for connections where it is desirable

The change looks good, but if you touch this, you might as well fix up
the comment style to match the normal kernel style:

/*
 * Define the socket priority to use for connections where it is desirable

Re: [PATCH v2] nvme/host: fixup some typos

[Wilfred Mallawa]

On Wed, 2026-01-07 at 11:09 +0100, Christoph Hellwig wrote:
> Bit: the subject prefix is we usually use is just "nvme: ".
> 
> >  	/*
> >  	 * Handle ioctls that apply to the controller instead of
> > the namespace
> > -	 * separately and drop the ns SRCU reference early.  This
> > avoids a
> > +	 * separately and drop the ns SRCU reference early. This
> > avoids a
> 
> I don't see a typo here, just a reformatting to a different comment
> style not very commonly used in the nvme code.

It's just the extra white space before the "This avoids". Is that not a
typo?

> 
> > -/* Define the socket priority to use for connections were it is
> > desirable
> > +/* Define the socket priority to use for connections where it is
> > desirable
> 
> The change looks good, but if you touch this, you might as well fix
> up
> the comment style to match the normal kernel style:
> 
> /*
>  * Define the socket priority to use for connections where it is
> desirable

Ah no worries, will fixup!

Wilfred

Re: [PATCH v2] nvme/host: fixup some typos

[hch]

On Wed, Jan 07, 2026 at 10:33:37AM +0000, Wilfred Mallawa wrote:
> > I don't see a typo here, just a reformatting to a different comment
> > style not very commonly used in the nvme code.
> 
> It's just the extra white space before the "This avoids". Is that not a
> typo?

Double spaces after the end of a sentence is common style for fixed
width font text and recommended by various (usually older) coding
guidelines.  But even typesetting for variable-sided fonts sometimes
add extra space, in TeX this is known as "french spacing"

Re: [PATCH v2] nvme/host: fixup some typos

[Wilfred Mallawa]

On Wed, 2026-01-07 at 14:15 +0100, hch wrote:
> On Wed, Jan 07, 2026 at 10:33:37AM +0000, Wilfred Mallawa wrote:
> > > I don't see a typo here, just a reformatting to a different
> > > comment
> > > style not very commonly used in the nvme code.
> > 
> > It's just the extra white space before the "This avoids". Is that
> > not a
> > typo?
> 
> Double spaces after the end of a sentence is common style for fixed
> width font text and recommended by various (usually older) coding
> guidelines.  But even typesetting for variable-sided fonts sometimes
> add extra space, in TeX this is known as "french spacing"
> 

Ah I see, thanks for letting me know!

Wilfred