* [PATCH v4] nvme/host: fixup some typos
@ 2026-01-14 6:37 Wilfred Mallawa
2026-02-11 4:28 ` Wilfred Mallawa
0 siblings, 1 reply; 4+ messages in thread
From: Wilfred Mallawa @ 2026-01-14 6:37 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme, linux-kernel
Cc: Damien Le Moal, Wilfred Mallawa
From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Fix up some minor typos/grammar in the nvme host tcp driver and a comment
style to conform to the standard kernel style.
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
V4:
- Minor grammar fixup
---
drivers/nvme/host/tcp.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 69cb04406b47..6658a5806dd9 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -25,7 +25,8 @@
struct nvme_tcp_queue;
-/* Define the socket priority to use for connections were it is desirable
+/*
+ * Define the socket priority to use for connections where it is desirable
* that the NIC consider performing optimized packet processing or filtering.
* A non-zero value being sufficient to indicate general consideration of any
* possible optimization. Making it a module param allows for alternative
@@ -926,8 +927,9 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb,
req->curr_bio = req->curr_bio->bi_next;
/*
- * If we don`t have any bios it means that controller
- * sent more data than we requested, hence error
+ * If we do not have any bios, it means that the
+ * controller sent more data than we requested,
+ * hence error
*/
if (!req->curr_bio) {
dev_err(queue->ctrl->ctrl.device,
--
2.52.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v4] nvme/host: fixup some typos
2026-01-14 6:37 [PATCH v4] nvme/host: fixup some typos Wilfred Mallawa
@ 2026-02-11 4:28 ` Wilfred Mallawa
2026-02-12 2:33 ` Keith Busch
0 siblings, 1 reply; 4+ messages in thread
From: Wilfred Mallawa @ 2026-02-11 4:28 UTC (permalink / raw)
To: kbusch@kernel.org, hch, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: dlemoal@kernel.org
On Wed, 2026-01-14 at 16:37 +1000, Wilfred Mallawa wrote:
Gentle ping, in-case this got lost in the threads :)
Wilfred
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Fix up some minor typos/grammar in the nvme host tcp driver and a
> comment
> style to conform to the standard kernel style.
>
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> V4:
> - Minor grammar fixup
> ---
> drivers/nvme/host/tcp.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> index 69cb04406b47..6658a5806dd9 100644
> --- a/drivers/nvme/host/tcp.c
> +++ b/drivers/nvme/host/tcp.c
> @@ -25,7 +25,8 @@
>
> struct nvme_tcp_queue;
>
> -/* Define the socket priority to use for connections were it is
> desirable
> +/*
> + * Define the socket priority to use for connections where it is
> desirable
> * that the NIC consider performing optimized packet processing or
> filtering.
> * A non-zero value being sufficient to indicate general
> consideration of any
> * possible optimization. Making it a module param allows for
> alternative
> @@ -926,8 +927,9 @@ static int nvme_tcp_recv_data(struct
> nvme_tcp_queue *queue, struct sk_buff *skb,
> req->curr_bio = req->curr_bio->bi_next;
>
> /*
> - * If we don`t have any bios it means that
> controller
> - * sent more data than we requested, hence
> error
> + * If we do not have any bios, it means that
> the
> + * controller sent more data than we
> requested,
> + * hence error
> */
> if (!req->curr_bio) {
> dev_err(queue->ctrl->ctrl.device,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v4] nvme/host: fixup some typos
2026-02-11 4:28 ` Wilfred Mallawa
@ 2026-02-12 2:33 ` Keith Busch
2026-02-12 2:40 ` Wilfred Mallawa
0 siblings, 1 reply; 4+ messages in thread
From: Keith Busch @ 2026-02-12 2:33 UTC (permalink / raw)
To: Wilfred Mallawa
Cc: hch, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
dlemoal@kernel.org
On Wed, Feb 11, 2026 at 04:28:53AM +0000, Wilfred Mallawa wrote:
> On Wed, 2026-01-14 at 16:37 +1000, Wilfred Mallawa wrote:
>
> Gentle ping, in-case this got lost in the threads :)
The previous version was already applied:
https://git.infradead.org/?p=nvme.git;a=commitdiff;h=f947d9e77b26238b821b5227afb4fee8c7ea0d5a
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] nvme/host: fixup some typos
2026-02-12 2:33 ` Keith Busch
@ 2026-02-12 2:40 ` Wilfred Mallawa
0 siblings, 0 replies; 4+ messages in thread
From: Wilfred Mallawa @ 2026-02-12 2:40 UTC (permalink / raw)
To: kbusch@kernel.org
Cc: hch, dlemoal@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
On Wed, 2026-02-11 at 19:33 -0700, Keith Busch wrote:
> On Wed, Feb 11, 2026 at 04:28:53AM +0000, Wilfred Mallawa wrote:
> > On Wed, 2026-01-14 at 16:37 +1000, Wilfred Mallawa wrote:
> >
> > Gentle ping, in-case this got lost in the threads :)
>
> The previous version was already applied:
Ah missed that, sorry for the noise!
Wilfred
>
>
> https://git.infradead.org/?p=nvme.git;a=commitdiff;h=f947d9e77b26238b821b5227afb4fee8c7ea0d5a
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-12 2:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-14 6:37 [PATCH v4] nvme/host: fixup some typos Wilfred Mallawa
2026-02-11 4:28 ` Wilfred Mallawa
2026-02-12 2:33 ` Keith Busch
2026-02-12 2:40 ` Wilfred Mallawa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox