From: Keith Busch <kbusch@meta.com>
To: <linux-nvme@lists.infradead.org>, <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>
Subject: [PATCH 3/3] nvme-pci: do not try to add queue maps at runtime
Date: Tue, 10 Feb 2026 11:37:15 -0800 [thread overview]
Message-ID: <20260210193715.2543091-3-kbusch@meta.com> (raw)
In-Reply-To: <20260210193715.2543091-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
The block layer allocates the set's maps once. We can't add special
purpose queues at runtime if they weren't allocated at initialization
time.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/pci.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index f6d5c242fb689..43d214d31a8cf 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2775,6 +2775,20 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
dev->nr_write_queues = write_queues;
dev->nr_poll_queues = poll_queues;
+ if (dev->ctrl.tagset) {
+ switch (dev->ctrl.tagset->nr_maps) {
+ case 1:
+ dev->nr_write_queues = 0;
+ dev->nr_poll_queues = 0;
+ break;
+ case 2:
+ dev->nr_poll_queues = 0;
+ break;
+ default:
+ break;
+ }
+ }
+
nr_io_queues = min(nvme_max_io_queues(dev),
dev->nr_allocated_queues - 1);
result = nvme_set_queue_count(&dev->ctrl, &nr_io_queues);
--
2.47.3
next prev parent reply other threads:[~2026-02-10 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 19:37 [PATCH 1/3] nvme-pci: ensure we're polling a polled queue Keith Busch
2026-02-10 19:37 ` [PATCH 2/3] nvme-pci: cap queue creation to used queues Keith Busch
2026-02-11 15:56 ` Christoph Hellwig
2026-02-12 14:57 ` Kanchan Joshi
2026-02-10 19:37 ` Keith Busch [this message]
2026-02-11 15:58 ` [PATCH 3/3] nvme-pci: do not try to add queue maps at runtime Christoph Hellwig
2026-02-11 15:56 ` [PATCH 1/3] nvme-pci: ensure we're polling a polled queue Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210193715.2543091-3-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox