From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 3/3] nvme-pci: do not try to add queue maps at runtime
Date: Wed, 11 Feb 2026 16:58:11 +0100 [thread overview]
Message-ID: <20260211155811.GC11325@lst.de> (raw)
In-Reply-To: <20260210193715.2543091-3-kbusch@meta.com>
On Tue, Feb 10, 2026 at 11:37:15AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The block layer allocates the set's maps once. We can't add special
> purpose queues at runtime if they weren't allocated at initialization
> time.
Same here, a comment in the code would be helpful.
> + if (dev->ctrl.tagset) {
> + switch (dev->ctrl.tagset->nr_maps) {
> + case 1:
> + dev->nr_write_queues = 0;
> + dev->nr_poll_queues = 0;
> + break;
> + case 2:
> + dev->nr_poll_queues = 0;
> + break;
Maybe use fallthrough or just two ifs to condense this a tiny bit?
Otherwise looks good.
next prev parent reply other threads:[~2026-02-11 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 19:37 [PATCH 1/3] nvme-pci: ensure we're polling a polled queue Keith Busch
2026-02-10 19:37 ` [PATCH 2/3] nvme-pci: cap queue creation to used queues Keith Busch
2026-02-11 15:56 ` Christoph Hellwig
2026-02-12 14:57 ` Kanchan Joshi
2026-02-10 19:37 ` [PATCH 3/3] nvme-pci: do not try to add queue maps at runtime Keith Busch
2026-02-11 15:58 ` Christoph Hellwig [this message]
2026-02-11 15:56 ` [PATCH 1/3] nvme-pci: ensure we're polling a polled queue Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211155811.GC11325@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox