From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A19CE9A053 for ; Thu, 19 Feb 2026 17:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cD5qcELz1szuWzdXkgd0fgG80WegTttIPZeozvdhos4=; b=AuWZ9X5Qfp4067NeWcwhjltYyp hYc2P8ZQiGXbkwPaO3+MZZu4chhywmD+mF95aWlvu3GTjQw2dV926NbgFnlyJlKYv+c8l541c5KJf JGtvoiRnbAAk5r76q3H7dECaQ+rAdOyuDh1ncakwgPYxxKVLgbQsk68SJbSV6PC/rFk1a4rK82oni GOoduDn4ljXHBsU7dFh3hY21VbkyZnmzFwxdLvcsT6BpS+ekQK+VZpA0ZaUuc59S/wTnRHaFd0587 rOuvefpJ2aMtjIbJBAVZUhcUigNtrhpzhlRyHty/AFSHcEpfAeQCUuZ/akehLmW7+OQw0JLt8UEkj jsXiVuHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vt7k5-0000000Bh1o-2u1h; Thu, 19 Feb 2026 17:23:09 +0000 Received: from mail-pl1-x661.google.com ([2607:f8b0:4864:20::661]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vt7k2-0000000Bh01-3zR5 for linux-nvme@lists.infradead.org; Thu, 19 Feb 2026 17:23:08 +0000 Received: by mail-pl1-x661.google.com with SMTP id d9443c01a7336-2ab08e6c553so432115ad.3 for ; Thu, 19 Feb 2026 09:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771521786; x=1772126586; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cD5qcELz1szuWzdXkgd0fgG80WegTttIPZeozvdhos4=; b=UpMJjzsU9abSjAhS9qBEhqxFfR4cSp0mY11SZfafNR+GZ7FGGwiOP1W+hMRNwnWtUF EAMzcpvAeaLtdCx1q045L/MxWKNbvDFmHWMJ1BU+vZgnG1upVxJg5aqjQDlzv0FMgVbW H/u/R4TTLkC73MRLdIf/tVIZkmOgYXUMHovVYqeTuUhf+HX83N+TVP9iVtodp9szlpvp SKzPh1m2BEQikok1lRun3/oTn+hBmuPnJJGWl+DpbQIGlD1qt6Pgv5WcyN2Xx670/19i nj+HUn/qNoqzp3w4CiEV/IgIHFLWEI0POkE/NCBkzSMK5M/0oaRaV5pWKMJi27eQY0l+ D55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771521786; x=1772126586; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cD5qcELz1szuWzdXkgd0fgG80WegTttIPZeozvdhos4=; b=VR9EcCl03wBLahevG6BEGGlNUiyS3EaEe+id104ZxmahVSZFIbiBnrgwEdOinxYeCn bw3K/FjHY/hKJy6RzFu259PBNhGRkAoeH030t3g+Eb1kteU++rP7ssPrEDJnbFMmA0wF gAAB+hueq+F1fAyJAw2phrt7F+SJTdoltl/Site5M3bC8ktTICCBvyp+UKvjbWfmpajB yDWtU5SQEfD9ElBkua8vDK36maHlIR0fKXzhWiAbPJB62SQmI/Lg038immcfLZXRlLDI rHQPHGLCFdBJCvvzHJ8b2X2mM8jkrw4D6Nwhyr4GxZyDrt2npa9MUL6PcISQqXqTOynO uxzA== X-Forwarded-Encrypted: i=1; AJvYcCW7fgJ1OfUxsgRzgEqlQvdXr6yaWYQL8fexG49opCIcUZ5KqZyy9Lglg4Ri6+5HyeV4uYxSBzOVOlZq@lists.infradead.org X-Gm-Message-State: AOJu0Yyq5G09xHv5TWtsjWDFIVO+Lc9e8prDV2d5Qyu0xchsCGjFpm7I 3TSo4BcaN//nKF+8mFAOV4runij/joT7zqKLSZ4KtW5q/5BAugdJ0+GPrf7kRnPpWBNcmLGaQ1g Vxkg1tjG/3CglA9JKdKGr9U/7AnFnXonS2KLfIU6yY8cMr6VeW2Ik X-Gm-Gg: AZuq6aK90mdIk5khlxkCL6RqKeJM7ZVQqs0CuTFv51RLPy5VwIzRjeFlIEnJyNszgNa rsvtSBLui8vBpXmu5dkAms8rKrlB/OSCh+uMWCsfmgRdQT1E2GrWebdzSUE/IdIshkUjvEuAFRS vCK+SYoD+78dMYvw9ZDBIfcwcE0a7eBZJkkFti4g27m87DS4IEYOGws4ihs8VXixBzvUg5q6z0w 5PS+SdhFRxjeZySf+Udrd/I2xk5qsVKN5d1q8WxjUc+EaODwubjRNescLgllOj0m5t5BTJS7Tmv gDL84kcahph1zpaKFj6YfYU+jYpqIXJlZx6/6CdIeOzhdRR4EOD4LLYmF3OKg6EmJyirbheiyxI kX/eHLLwYtIdVePP9cXqgBCkimm2wEBUmDAdG98U= X-Received: by 2002:a17:903:1b63:b0:2a7:8bf3:5674 with SMTP id d9443c01a7336-2ab4cb003e4mr163336915ad.0.1771521785949; Thu, 19 Feb 2026 09:23:05 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ad1a78f7c0sm21662705ad.28.2026.02.19.09.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 09:23:05 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 2F5A4342181; Thu, 19 Feb 2026 10:23:05 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 27164E41AE3; Thu, 19 Feb 2026 10:23:05 -0700 (MST) From: Caleb Sander Mateos To: Jens Axboe , Christoph Hellwig , Keith Busch , Sagi Grimberg Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Anuj gupta , Kanchan Joshi , Caleb Sander Mateos Subject: [PATCH v3 3/4] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL Date: Thu, 19 Feb 2026 10:22:26 -0700 Message-ID: <20260219172228.429479-4-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260219172228.429479-1-csander@purestorage.com> References: <20260219172228.429479-1-csander@purestorage.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260219_092306_983480_40746BE3 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Currently, creating an io_uring with IORING_SETUP_IOPOLL requires all requests issued to it to support iopoll. This prevents, for example, using ublk zero-copy together with IORING_SETUP_IOPOLL, as ublk zero-copy buffer registrations are performed using a uring_cmd. There's no technical reason why these non-iopoll uring_cmds can't be supported. They will either complete synchronously or via an external mechanism that calls io_uring_cmd_done(), so they don't need to be polled. Allow uring_cmd requests to be issued to IORING_SETUP_IOPOLL io_urings even if their files don't implement ->uring_cmd_iopoll(). For these uring_cmd requests, skip initializing struct io_kiocb's iopoll fields, don't set REQ_F_IOPOLL, and don't set IO_URING_F_IOPOLL in issue_flags. Signed-off-by: Caleb Sander Mateos --- io_uring/uring_cmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c index b651c63f6e20..7b25dcd9d05f 100644 --- a/io_uring/uring_cmd.c +++ b/io_uring/uring_cmd.c @@ -255,13 +255,11 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) issue_flags |= IO_URING_F_SQE128; if (ctx->flags & (IORING_SETUP_CQE32 | IORING_SETUP_CQE_MIXED)) issue_flags |= IO_URING_F_CQE32; if (io_is_compat(ctx)) issue_flags |= IO_URING_F_COMPAT; - if (ctx->flags & IORING_SETUP_IOPOLL) { - if (!file->f_op->uring_cmd_iopoll) - return -EOPNOTSUPP; + if (ctx->flags & IORING_SETUP_IOPOLL && file->f_op->uring_cmd_iopoll) { req->flags |= REQ_F_IOPOLL; issue_flags |= IO_URING_F_IOPOLL; req->iopoll_completed = 0; if (ctx->flags & IORING_SETUP_HYBRID_IOPOLL) { /* make sure every req only blocks once */ -- 2.45.2