From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CC5DEC110E for ; Mon, 23 Feb 2026 17:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v4NzWXM4tpHzJDOwTGT86JiglGjnpcPu7UVk/0b1E2c=; b=N9p4R83dfEKeWeMl0u+fy3E7P4 qZrfKC3KMIm0Sgv/xGppmvo7/og0ITdjY5vwBt1UUeYtkBQhadS1IC+fXuOIHoumNI5E5wltdN4kn pLL83CaxnEtTSiNv0+JsldKoCsN6bgOfp4AQiG68A3vckX3aAJASzo06vXaTXPcIlvpnBxmoMiVGW xOwO8kzKjzvPUVWQo8Th8x9ZHif8ZjxCIcYQrDvzbGUiwttIy5Q9uEELHhp3escPxVKUG2a3HsZQ+ CFCtOcrA+Hy3tRF9IHYeIhfhUVb3g3jRrrzy2KRXVf0Qj8VoQWLO72gGsReFikKq9Y3YsAmlBYs5k FUHdPl5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuZf1-00000000lvd-1EOH; Mon, 23 Feb 2026 17:23:55 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuZex-00000000lsr-39JS for linux-nvme@lists.infradead.org; Mon, 23 Feb 2026 17:23:53 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-8249aca0affso2384774b3a.3 for ; Mon, 23 Feb 2026 09:23:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudlinux.com; s=google; t=1771867431; x=1772472231; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v4NzWXM4tpHzJDOwTGT86JiglGjnpcPu7UVk/0b1E2c=; b=ECF8oFH+063/71HHDE71xb7qMdwTPNjLZMpDJoLlTsbxfchAIssfsliwo0rjKhglHB h37mZE9G3KrygWaimg3nW5UQFHVJJckAFMANfZQ3DGaPmu4whHSiPMWY6osg+pAzgt8o no0M5nQ2wxEH3q5oAhHn7D7jB5CXWeswhG/gdQJRrWRViOCzC361POvUKhknarucHsR7 DefKxfllO7123y+eqYRSuYPcl34lZ+6wN+F+iheXfb2k0NO8SmDDd3O0C/2vmoiR+jQG OnniD8mn1DqZQ68tipnpEETyJzD2EcPhq+3nDRZFrZleTlc79x5bd+zY+0vrO1tZSZeY ysdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771867431; x=1772472231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v4NzWXM4tpHzJDOwTGT86JiglGjnpcPu7UVk/0b1E2c=; b=rYN+zp3IvUiRKXIydbs1WAnQHoP1PHdY35B++2cAyX6Onjt89j19opEbMZwQDSr157 XHdlVqNZFx6lpp0HVIyYNjPmMY+Otiy2hF2nsPXRVJko2YX4KffXeAxN1qsQTapzw72T tbk0OQIzU2UC49Wlm1jFNy+q2rTQHLFQWRNsw3zK8iqtTcvwWbQkBpz85BM4UXXZ3kQ5 gIX5iDg0ncujDf4kSoJ7+wACXGSXVVkwE6HupplfE/9o5b9QOq3bSlgH4iyRhUn9grZj einXKnAnlO3KTuErYQY9zXOeYFZggS6p2D2EJUGeV5KNHc9RhpMJOq+mfn9IPaFuRw/+ JQig== X-Gm-Message-State: AOJu0Ywto9HoMe7tj4Gu0Jh77Vd9sIPVvpn1OtzE67v29i/hfFe0iMFG 1SqI49FXjjuDc0AEN1EPdhJqv3PQ58YbDCpBmAUeLp4WooO7aa6qTaqKmEqIpTFfzB8= X-Gm-Gg: AZuq6aJXFBT/6kd2a19PHjlaK4L0OhSdBfbLhDft6/NQN0WGa3fqMUA4bm4KMUAMGAy R9pqQeluP8viuVHfxxwe5nDkQKmvXcCvW0A8BdKrs4MiRbqnymjX/QzOb6nTqc00xxM5+A+5qID rZT3HxhNln0da0s5eZKeedR13HqdbYNqeL1+hlxyw7+PPlcVWRoqdfmnaGnTj2HKqn+kCRFUpnX VfguLJxQGTlpNcWwSFilETkfl8qFfAcQd/aySHs7iVjHaHoM36vHBxdRITVWkAxVgBwIoVXZs5w rMYAWPxpcGlME/Q6mDSgDEx6wkV8H+E15m2mrM8SeKAE3L9FsxwNagK6x4y8x2sdYFdmVRE+ROy NZpSfiMxogmA2oMZwv7guGMpa9Rrf3VHWTD2m7P3mva3b+pCd9Cj9stxCMNNS/TGRMaChAi3zKH YwTlNLULx4t2UBOPZk+gqoMVYCHzC/fcY= X-Received: by 2002:a05:6a00:3e0c:b0:821:8202:44e3 with SMTP id d2e1a72fcca58-826daa022fbmr8898341b3a.30.1771867430896; Mon, 23 Feb 2026 09:23:50 -0800 (PST) Received: from outpost.localdomain ([110.44.9.85]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd641313sm7876162b3a.1.2026.02.23.09.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 09:23:50 -0800 (PST) From: Jaskaran Singh To: stable@vger.kernel.org, james.smart@broadcom.com, kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Jaskaran Singh , Marco Patalano , Justin Tee , "Ewan D . Milne" Subject: [PATCH 5.15.y 2/2] nvme: nvme-fc: Ensure ->ioerr_work is cancelled in nvme_fc_delete_ctrl() Date: Mon, 23 Feb 2026 22:53:32 +0530 Message-Id: <20260223172332.291881-3-jsingh@cloudlinux.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260223172332.291881-1-jsingh@cloudlinux.com> References: <20260223172332.291881-1-jsingh@cloudlinux.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260223_092351_814307_EDC7DFA5 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org commit 0a2c5495b6d1ecb0fa18ef6631450f391a888256 upstream. nvme_fc_delete_assocation() waits for pending I/O to complete before returning, and an error can cause ->ioerr_work to be queued after cancel_work_sync() had been called. Move the call to cancel_work_sync() to be after nvme_fc_delete_association() to ensure ->ioerr_work is not running when the nvme_fc_ctrl object is freed. Otherwise the following can occur: [ 1135.911754] list_del corruption, ff2d24c8093f31f8->next is NULL [ 1135.917705] ------------[ cut here ]------------ [ 1135.922336] kernel BUG at lib/list_debug.c:52! [ 1135.926784] Oops: invalid opcode: 0000 [#1] SMP NOPTI [ 1135.931851] CPU: 48 UID: 0 PID: 726 Comm: kworker/u449:23 Kdump: loaded Not tainted 6.12.0 #1 PREEMPT(voluntary) [ 1135.943490] Hardware name: Dell Inc. PowerEdge R660/0HGTK9, BIOS 2.5.4 01/16/2025 [ 1135.950969] Workqueue: 0x0 (nvme-wq) [ 1135.954673] RIP: 0010:__list_del_entry_valid_or_report.cold+0xf/0x6f [ 1135.961041] Code: c7 c7 98 68 72 94 e8 26 45 fe ff 0f 0b 48 c7 c7 70 68 72 94 e8 18 45 fe ff 0f 0b 48 89 fe 48 c7 c7 80 69 72 94 e8 07 45 fe ff <0f> 0b 48 89 d1 48 c7 c7 a0 6a 72 94 48 89 c2 e8 f3 44 fe ff 0f 0b [ 1135.979788] RSP: 0018:ff579b19482d3e50 EFLAGS: 00010046 [ 1135.985015] RAX: 0000000000000033 RBX: ff2d24c8093f31f0 RCX: 0000000000000000 [ 1135.992148] RDX: 0000000000000000 RSI: ff2d24d6bfa1d0c0 RDI: ff2d24d6bfa1d0c0 [ 1135.999278] RBP: ff2d24c8093f31f8 R08: 0000000000000000 R09: ffffffff951e2b08 [ 1136.006413] R10: ffffffff95122ac8 R11: 0000000000000003 R12: ff2d24c78697c100 [ 1136.013546] R13: fffffffffffffff8 R14: 0000000000000000 R15: ff2d24c78697c0c0 [ 1136.020677] FS: 0000000000000000(0000) GS:ff2d24d6bfa00000(0000) knlGS:0000000000000000 [ 1136.028765] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1136.034510] CR2: 00007fd207f90b80 CR3: 000000163ea22003 CR4: 0000000000f73ef0 [ 1136.041641] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1136.048776] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400 [ 1136.055910] PKRU: 55555554 [ 1136.058623] Call Trace: [ 1136.061074] [ 1136.063179] ? show_trace_log_lvl+0x1b0/0x2f0 [ 1136.067540] ? show_trace_log_lvl+0x1b0/0x2f0 [ 1136.071898] ? move_linked_works+0x4a/0xa0 [ 1136.075998] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.081744] ? __die_body.cold+0x8/0x12 [ 1136.085584] ? die+0x2e/0x50 [ 1136.088469] ? do_trap+0xca/0x110 [ 1136.091789] ? do_error_trap+0x65/0x80 [ 1136.095543] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.101289] ? exc_invalid_op+0x50/0x70 [ 1136.105127] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.110874] ? asm_exc_invalid_op+0x1a/0x20 [ 1136.115059] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.120806] move_linked_works+0x4a/0xa0 [ 1136.124733] worker_thread+0x216/0x3a0 [ 1136.128485] ? __pfx_worker_thread+0x10/0x10 [ 1136.132758] kthread+0xfa/0x240 [ 1136.135904] ? __pfx_kthread+0x10/0x10 [ 1136.139657] ret_from_fork+0x31/0x50 [ 1136.143236] ? __pfx_kthread+0x10/0x10 [ 1136.146988] ret_from_fork_asm+0x1a/0x30 [ 1136.150915] Fixes: 19fce0470f05 ("nvme-fc: avoid calling _nvme_fc_abort_outstanding_ios from interrupt context") Cc: stable@vger.kernel.org Tested-by: Marco Patalano Reviewed-by: Justin Tee Signed-off-by: Ewan D. Milne Signed-off-by: Keith Busch Signed-off-by: Greg Kroah-Hartman Signed-off-by: Jaskaran Singh --- drivers/nvme/host/fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index a959b2c9ae38..9381655c1ec5 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -3263,13 +3263,13 @@ nvme_fc_delete_ctrl(struct nvme_ctrl *nctrl) { struct nvme_fc_ctrl *ctrl = to_fc_ctrl(nctrl); - cancel_work_sync(&ctrl->ioerr_work); cancel_delayed_work_sync(&ctrl->connect_work); /* * kill the association on the link side. this will block * waiting for io to terminate */ nvme_fc_delete_association(ctrl); + cancel_work_sync(&ctrl->ioerr_work); } static void -- 2.43.7