From: Caleb Sander Mateos <csander@purestorage.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Caleb Sander Mateos <csander@purestorage.com>
Subject: [PATCH v4 1/8] nvme: add preferred I/O size fields to struct nvme_id_ns_nvm
Date: Thu, 26 Feb 2026 12:04:08 -0700 [thread overview]
Message-ID: <20260226190416.297725-2-csander@purestorage.com> (raw)
In-Reply-To: <20260226190416.297725-1-csander@purestorage.com>
A subsequent change will use the NPDGL and NPDAL fields of the NVM
Command Set Specific Identify Namespace structure, so add them (and the
handful of intervening fields) to struct nvme_id_ns_nvm. Add an
assertion that the size is still 4 KB.
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
include/linux/nvme.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 655d194f8e72..1134e6bf2d5c 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -511,13 +511,20 @@ struct nvme_id_ctrl_zns {
struct nvme_id_ns_nvm {
__le64 lbstm;
__u8 pic;
__u8 rsvd9[3];
__le32 elbaf[64];
- __u8 rsvd268[3828];
+ __le32 npdgl;
+ __le32 nprg;
+ __le32 npra;
+ __le32 nors;
+ __le32 npdal;
+ __u8 rsvd288[3808];
};
+static_assert(sizeof(struct nvme_id_ns_nvm) == 4096);
+
enum {
NVME_ID_NS_NVM_STS_MASK = 0x7f,
NVME_ID_NS_NVM_GUARD_SHIFT = 7,
NVME_ID_NS_NVM_GUARD_MASK = 0x3,
NVME_ID_NS_NVM_QPIF_SHIFT = 9,
--
2.45.2
next prev parent reply other threads:[~2026-02-26 19:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 19:04 [PATCH v4 0/8] nvme: set discard_granularity from NPDG/NPDA Caleb Sander Mateos
2026-02-26 19:04 ` Caleb Sander Mateos [this message]
2026-02-26 19:04 ` [PATCH v4 2/8] nvme: fold nvme_config_discard() into nvme_update_disk_info() Caleb Sander Mateos
2026-02-26 19:04 ` [PATCH v4 3/8] nvme: update nvme_id_ns OPTPERF constants Caleb Sander Mateos
2026-02-26 19:04 ` [PATCH v4 4/8] nvme: always issue I/O Command Set specific Identify Namespace Caleb Sander Mateos
2026-02-26 21:02 ` Keith Busch
2026-02-26 21:06 ` Caleb Sander Mateos
2026-02-26 19:04 ` [PATCH v4 5/8] nvme: add from0based() helper Caleb Sander Mateos
2026-02-26 19:04 ` [PATCH v4 6/8] nvme: set discard_granularity from NPDG/NPDA Caleb Sander Mateos
2026-02-26 21:20 ` Keith Busch
2026-02-26 19:04 ` [PATCH v4 7/8] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT Caleb Sander Mateos
2026-02-26 19:04 ` [PATCH v4 8/8] nvmet: report NPDGL and NPDAL Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226190416.297725-2-csander@purestorage.com \
--to=csander@purestorage.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox