* [PATCH] nvme: update comment about invalid LBA size
@ 2026-02-27 10:23 John Garry
2026-02-27 13:50 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: John Garry @ 2026-02-27 10:23 UTC (permalink / raw)
To: hch, kbusch, sagi, axboe; +Cc: linux-nvme, mcgrof, John Garry
We have supported LBA size > PAGE_SIZE for some time now, so update the
relevant comment in nvme_update_disk_info().
Signed-off-by: John Garry <john.g.garry@oracle.com>
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 3a2126584a236..c5ed0536b040a 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2085,8 +2085,7 @@ static bool nvme_update_disk_info(struct nvme_ns *ns, struct nvme_id_ns *id,
bool valid = true;
/*
- * The block layer can't support LBA sizes larger than the page size
- * or smaller than a sector size yet, so catch this early and don't
+ * Catch LBA sizes which the block layer can't support early and don't
* allow block I/O.
*/
if (blk_validate_block_size(bs)) {
--
2.43.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme: update comment about invalid LBA size
2026-02-27 10:23 [PATCH] nvme: update comment about invalid LBA size John Garry
@ 2026-02-27 13:50 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2026-02-27 13:50 UTC (permalink / raw)
To: John Garry; +Cc: hch, kbusch, sagi, axboe, linux-nvme, mcgrof
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-27 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 10:23 [PATCH] nvme: update comment about invalid LBA size John Garry
2026-02-27 13:50 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox