public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Caleb Sander Mateos <csander@purestorage.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Caleb Sander Mateos <csander@purestorage.com>
Subject: [PATCH v5 5/8] nvme: add from0based() helper
Date: Fri, 27 Feb 2026 13:23:50 -0700	[thread overview]
Message-ID: <20260227202354.1012322-6-csander@purestorage.com> (raw)
In-Reply-To: <20260227202354.1012322-1-csander@purestorage.com>

The NVMe specifications are big fans of "0's based"/"0-based" fields for
encoding values that must be positive. The encoded value is 1 less than
the value it represents. nvmet already provides a helper to0based() for
encoding 0's based values, so add a corresponding helper to decode these
fields on the host side.

Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 drivers/nvme/host/nvme.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 9971045dbc05..ccd5e05dac98 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -760,10 +760,16 @@ static inline sector_t nvme_lba_to_sect(struct nvme_ns_head *head, u64 lba)
 static inline u32 nvme_bytes_to_numd(size_t len)
 {
 	return (len >> 2) - 1;
 }
 
+/* Decode a 2-byte "0's based"/"0-based" field */
+static inline u32 from0based(__le16 value)
+{
+	return (u32)le16_to_cpu(value) + 1;
+}
+
 static inline bool nvme_is_ana_error(u16 status)
 {
 	switch (status & NVME_SCT_SC_MASK) {
 	case NVME_SC_ANA_TRANSITION:
 	case NVME_SC_ANA_INACCESSIBLE:
-- 
2.45.2



  parent reply	other threads:[~2026-02-27 20:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 20:23 [PATCH v5 0/8] nvme: set discard_granularity from NPDG/NPDA Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 1/8] nvme: add preferred I/O size fields to struct nvme_id_ns_nvm Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 2/8] nvme: fold nvme_config_discard() into nvme_update_disk_info() Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 3/8] nvme: update nvme_id_ns OPTPERF constants Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 4/8] nvme: always issue I/O Command Set specific Identify Namespace Caleb Sander Mateos
2026-02-27 20:23 ` Caleb Sander Mateos [this message]
2026-02-27 20:23 ` [PATCH v5 6/8] nvme: set discard_granularity from NPDG/NPDA Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 7/8] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 8/8] nvmet: report NPDGL and NPDAL Caleb Sander Mateos
2026-03-02 18:54 ` [PATCH v5 0/8] nvme: set discard_granularity from NPDG/NPDA Keith Busch
2026-03-02 19:04   ` Caleb Sander Mateos
2026-03-23 15:29   ` Caleb Sander Mateos
2026-03-23 18:37     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227202354.1012322-6-csander@purestorage.com \
    --to=csander@purestorage.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox