Re: [PATCH 18/21] nvme-auth: target: use crypto library in nvmet_auth_ctrl_hash()

Hannes Reinecke
2026-03-03T07:44:45Z

On 3/2/26 08:59, Eric Biggers wrote:
> For the HMAC computation in nvmet_auth_ctrl_hash(), use the crypto
> library instead of crypto_shash. This is simpler, faster, and more
> reliable. Notably, this eliminates the crypto transformation object
> allocation for every call, which was very slow.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> drivers/nvme/target/auth.c | 94 ++++++++++----------------------------
> 1 file changed, 25 insertions(+), 69 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich