Re: [PATCH 20/21] nvme-auth: common: remove selections of no-longer used crypto modules

Hannes Reinecke
2026-03-03T07:45:46Z

On 3/2/26 08:59, Eric Biggers wrote:
> Now that nvme-auth uses the crypto library instead of crypto_shash,
> remove obsolete selections from the NVME_AUTH kconfig option.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> drivers/nvme/common/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/nvme/common/Kconfig b/drivers/nvme/common/Kconfig
> index 1ec507d1f9b5f..f1639db65fd38 100644
> --- a/drivers/nvme/common/Kconfig
> +++ b/drivers/nvme/common/Kconfig
> @@ -5,16 +5,12 @@ config NVME_KEYRING
> select KEYS
>
> config NVME_AUTH
> tristate
> select CRYPTO
> - select CRYPTO_HMAC
> - select CRYPTO_SHA256
> - select CRYPTO_SHA512
> select CRYPTO_DH
> select CRYPTO_DH_RFC7919_GROUPS
> - select CRYPTO_HKDF
> select CRYPTO_LIB_SHA256
> select CRYPTO_LIB_SHA512
>
> config NVME_AUTH_KUNIT_TEST
> tristate "KUnit tests for NVMe authentication" if !KUNIT_ALL_TESTS

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich