Re: [PATCH 03/21] nvme-auth: use proper argument types

Hannes Reinecke
2026-03-02T09:46:07Z

On 3/2/26 08:59, Eric Biggers wrote:
> For input parameters, use pointer to const. This makes it easier to
> understand which parameters are inputs and which are outputs.
>
> In addition, consistently use char for strings and u8 for binary. This
> makes it easier to understand what is a string and what is binary data.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> drivers/nvme/common/auth.c | 47 ++++++++++++++++++++-----------------
> drivers/nvme/host/auth.c | 3 ++-
> drivers/nvme/target/auth.c | 5 ++--
> drivers/nvme/target/nvmet.h | 2 +-
> include/linux/nvme-auth.h | 26 ++++++++++----------
> 5 files changed, 44 insertions(+), 39 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich