From: Christoph Hellwig <hch@lst.de>
To: alistair23@gmail.com
Cc: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alistair Francis <alistair.francis@wdc.com>,
Kamaljit Singh <kamaljit.singh@opensource.wdc.com>
Subject: Re: [PATCH] nvme-auth: Don't propose NVME_AUTH_DHGROUP_NULL with SC_C
Date: Fri, 6 Mar 2026 15:54:09 +0100 [thread overview]
Message-ID: <20260306145409.GA18945@lst.de> (raw)
In-Reply-To: <20260306041806.2321074-1-alistair.francis@wdc.com>
On Fri, Mar 06, 2026 at 02:18:06PM +1000, alistair23@gmail.com wrote:
> + u8 dh_list_offset = 30;
Can you add a symbolic name for this while we're at it and reuse it for
the dhchap.dhlen assignment.
> + if (chap->sc_c == NVME_AUTH_SECP_NOSC)
> + data->auth_protocol[0].dhchap.idlist[dh_list_offset++] = NVME_AUTH_DHGROUP_NULL;
> + data->auth_protocol[0].dhchap.idlist[dh_list_offset++] = NVME_AUTH_DHGROUP_2048;
And please add a local variable pointing data->auth_protocol[0].dhchap.idlist
to make this somewhat readable.
prev parent reply other threads:[~2026-03-06 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 4:18 [PATCH] nvme-auth: Don't propose NVME_AUTH_DHGROUP_NULL with SC_C alistair23
2026-03-06 14:54 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306145409.GA18945@lst.de \
--to=hch@lst.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=kamaljit.singh@opensource.wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox