From: Christoph Hellwig <hch@lst.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-tcp.h: drop kernel-doc comments, fix a few descriptions
Date: Mon, 16 Mar 2026 17:14:41 +0100 [thread overview]
Message-ID: <20260316161441.GA21005@lst.de> (raw)
In-Reply-To: <20260314040421.1499586-1-rdunlap@infradead.org>
On Fri, Mar 13, 2026 at 09:04:21PM -0700, Randy Dunlap wrote:
> Expand @fei into @feil and @feih because the field was split due to it
> not being 32-bit aligned.
>
> Struct member @hdr was described twice in struct nvme_tcp_rsp_pdu, so
> drop one of them.
>
> These structs are defined in a spec outside of the kernel, so kernel-doc
> comments for them aren't needed here as well.
>
> This avoids kernel-doc warnings:
I would have just dropped the comment entirely except for a reference
to the spec, but let's get the warning fixed instead of bikeshedding
for now:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-03-16 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 4:04 [PATCH] nvme-tcp.h: drop kernel-doc comments, fix a few descriptions Randy Dunlap
2026-03-16 16:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316161441.GA21005@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox