From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25D57109E558 for ; Thu, 26 Mar 2026 06:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t2ntQEOEcanTafxNq81vpHGZ4LjkAKhBeN0wp4QGX/8=; b=4EKumSQTZ5TrzTML3jJYKh2m5K uUeGDhRMOt3bVX44Ys5i2MVFfyOACKsGJv81carb9xQ6ZQx3NR0IFgdW9c7bl6iVzG65xJLEEVj4X /2vWKs0pnTfipRLIiV3pGqWKeKIArXPbqpI+7Kf8LzALITj4qKsxkN/H1Tsot8r7awDRMUSMnLWbb tgtvdOdNy2DrMWS3KQZ12IX69IowHn2fBF5Hx+le+/g+VbAg5D5VDegusROeIwqY460WQZegEC/0Q nnOXlqGPEbtLsHEEOAmVKzEJXtzQjM9lx996V9pAas5R40zLY4VmrbEDaKtkexOZis0PWPPAlx1Ls MXbZYEvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5dzW-00000004mlY-3FLf; Thu, 26 Mar 2026 06:14:50 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5dzT-00000004ml5-42RF; Thu, 26 Mar 2026 06:14:49 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4815768B05; Thu, 26 Mar 2026 07:14:43 +0100 (CET) Date: Thu, 26 Mar 2026 07:14:43 +0100 From: "hch@lst.de" To: =?utf-8?B?7KCE66+87Iud?= Cc: Keith Busch , Justin Tee , "axboe@kernel.dk" , "sven@kernel.org" , "j@jannau.net" , "neal@gompa.dev" , "hch@lst.de" , "sagi@grimberg.me" , "justin.tee@broadcom.com" , "nareshgottumukkala83@gmail.com" , "paul.ely@broadcom.com" , James Smart , "kch@nvidia.com" , "linux-arm-kernel@lists.infradead.org" , "linux-nvme@lists.infradead.org" , "asahi@lists.linux.dev" , "linux-kernel@vger.kernel.org" , =?utf-8?B?7J207J2A7IiY?= , =?utf-8?B?7Lm47LCs?= Subject: Re: [PATCH v4] nvme: Skip trace complete_rq on host path error Message-ID: <20260326061443.GA23850@lst.de> References: <20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6@epcms2p4> <945a3e98-ee75-453c-ae80-f3c9e3e57e58@gmail.com> <20260325063333epcms2p60954532c1b65a1665bad6dcdcfd7d62c@epcms2p6> <20260326014429epcms2p135ffd3c2b2fface6423d045e9614c262@epcms2p1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326014429epcms2p135ffd3c2b2fface6423d045e9614c262@epcms2p1> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260325_231448_147484_F443286F X-CRM114-Status: UNSURE ( 7.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > - trace_nvme_complete_rq(req); > + if (nvme_req(req)->status != NVME_SC_HOST_PATH_ERROR) > + trace_nvme_complete_rq(req); > + Please add a comment here explaining why we need the check.