From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@arkamax.eu>
Cc: Christoph Hellwig <hch@lst.de>,
Shivam Kumar <kumar.shivam43666@gmail.com>,
gregkh@linuxfoundation.org, security@kernel.org,
sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet-tcp: bound sgl->length check in nvmet_tcp_map_data()
Date: Thu, 9 Apr 2026 08:08:35 +0200 [thread overview]
Message-ID: <20260409060835.GA6389@lst.de> (raw)
In-Reply-To: <DHNK8IM7F6PF.1LX1Z2KTRK5JO@arkamax.eu>
On Wed, Apr 08, 2026 at 08:30:12AM +0200, Maurizio Lombardi wrote:
> Personally, I would pick a default of 2 MiB, it should be large
> enough to avoid excessive splitting while still being reasonable from a
> memory perspective.
>
> Sagi? Any thought on that?
>
> I have seen a patch on this mailing list that makes mdts configurable
> via configfs, so in case of need a user could still change it
> to his preferred value.
Right now that just allows adjusting down, so picking the larger
value sounds sane. We can still increase it later and/or allow
adjusting above the default to an upper cap if needed.
prev parent reply other threads:[~2026-04-09 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2026031805-stretch-skid-ae5b@gregkh>
2026-03-19 1:26 ` [PATCH] nvmet-tcp: bound sgl->length check in nvmet_tcp_map_data() Shivam Kumar
2026-03-19 7:59 ` Maurizio Lombardi
2026-03-19 18:00 ` Shivam Kumar
2026-03-20 7:48 ` Christoph Hellwig
2026-04-05 19:46 ` Shivam Kumar
2026-04-07 6:30 ` Christoph Hellwig
2026-04-08 6:30 ` Maurizio Lombardi
2026-04-09 6:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409060835.GA6389@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=kch@nvidia.com \
--cc=kumar.shivam43666@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@arkamax.eu \
--cc=sagi@grimberg.me \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox