From: Nilay Shroff <nilay@linux.ibm.com>
To: linux-nvme@lists.infradead.org
Cc: dwagner@suse.de, hare@suse.com, kbusch@kernel.org, hch@lst.de,
gjoyce@linux.ibm.com, wenxiong@linux.ibm.com,
Nilay Shroff <nilay@linux.ibm.com>
Subject: [PATCHv3 8/9] libnvme: add support for nshead diagnostic counters
Date: Tue, 21 Apr 2026 20:20:29 +0530 [thread overview]
Message-ID: <20260421145038.3458987-9-nilay@linux.ibm.com> (raw)
In-Reply-To: <20260421145038.3458987-1-nilay@linux.ibm.com>
Add support for retrieving nshead diagnostic counters such as requeue_
no_usable_path_count and fail_no_available_path_count.
The requeue_no_usable_path_count counter represents the number of I/Os
requeued to the namespace head when no usable path is available (for
example, due to transient link issues). The fail_no_available_path_count
counter represents the number of I/Os failed when no I/O path is
available (for example, when all paths are removed).
These counters improve visibility into NVMe native multipath behavior
and can be useful for tools such as nvme-top to display real-time
statistics.
Unlike other sysfs attributes, these counters can change dynamically.
Annotate them with "!accessors:none" and provide custom implementations
to always retrieve the latest (non-cached) values.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/libnvme.ld | 2 ++
libnvme/src/nvme/private.h | 2 ++
libnvme/src/nvme/tree.c | 22 ++++++++++++++++++++++
libnvme/src/nvme/tree.h | 17 +++++++++++++++++
4 files changed, 43 insertions(+)
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 2fafd333c..c9841e45c 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -142,6 +142,8 @@ LIBNVME_3 {
libnvme_ns_get_io_ticks;
libnvme_ns_get_command_retry_count;
libnvme_ns_get_command_error_count;
+ libnvme_ns_get_requeue_no_usable_path_count;
+ libnvme_ns_get_fail_no_available_path_count;
libnvme_ns_identify;
libnvme_ns_read;
libnvme_ns_verify;
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index ec0e1e848..170445927 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -254,6 +254,8 @@ struct libnvme_ns { // !generate-accessors
long command_retry_count; //!accessors:none
long command_error_count; //!accessors:none
+ long requeue_no_usable_path_count; //!accessors:none
+ long fail_no_available_path_count; //!accessors:none
};
struct libnvme_ctrl { // !generate-accessors
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index f1a1311b7..085d79558 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -2633,6 +2633,28 @@ __public long libnvme_ns_get_command_error_count(libnvme_ns_t n)
return n->command_error_count;
}
+__public long libnvme_ns_get_requeue_no_usable_path_count(libnvme_ns_t n)
+{
+ __cleanup_free char *requeue_count = NULL;
+
+ requeue_count = libnvme_get_ns_attr(n, "requeue_no_usable_path_count");
+ if (requeue_count)
+ sscanf(requeue_count, "%ld", &n->requeue_no_usable_path_count);
+
+ return n->requeue_no_usable_path_count;
+}
+
+__public long libnvme_ns_get_fail_no_available_path_count(libnvme_ns_t n)
+{
+ __cleanup_free char *fail_count = NULL;
+
+ fail_count = libnvme_get_ns_attr(n, "fail_no_available_path_count");
+ if (fail_count)
+ sscanf(fail_count, "%ld", &n->fail_no_available_path_count);
+
+ return n->fail_no_available_path_count;
+}
+
__public int libnvme_ns_identify(libnvme_ns_t n, struct nvme_id_ns *ns)
{
struct libnvme_transport_handle *hdl;
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index 63cd20838..6bfc8cf98 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -527,6 +527,23 @@ long libnvme_ns_get_command_retry_count(libnvme_ns_t n);
*/
long libnvme_ns_get_command_error_count(libnvme_ns_t n);
+/**
+ * libnvme_ns_get_requeue_no_usable_path_count() - Get num of I/O requeue count
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Number of I/Os which are re-queued due to the unavalibility of
+ * any usable path (maybe path is currently experiencing transinet link failure)
+ */
+long libnvme_ns_get_requeue_no_usable_path_count(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_fail_no_available_path_count() - Get num of I/Os forced to fail
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Number of I/Os which are forced to fail due to no path available
+ */
+long libnvme_ns_get_fail_no_available_path_count(libnvme_ns_t n);
+
/**
* libnvme_ns_get_generic_name() - Returns name of generic namespace chardev.
* @n: Namespace instance
--
2.53.0
next prev parent reply other threads:[~2026-04-21 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 1/9] libnvme: annotate libnvme_path::ana_state with !accessors:none Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 2/9] libnvme: annotate libnvme_path::numa_nodes " Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 3/9] libnvme: annotate libnvme_subsystem::iopolicy " Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 4/9] libnvme: add support for retrieving per-path gendisk I/O statistics Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 5/9] libnvme: add support for retrieving namespace " Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 6/9] libnvme: add support for per-path diagnostic counters Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 7/9] libnvme: add support for namespace " Nilay Shroff
2026-04-21 14:50 ` Nilay Shroff [this message]
2026-04-21 14:50 ` [PATCHv3 9/9] libnvme: add support for ctrl " Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421145038.3458987-9-nilay@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox