From: Tokunori Ikegami <ikegami.t@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nvme@lists.infradead.org, Tokunori Ikegami <ikegami.t@gmail.com>
Subject: [PATCH v2 2/2] nvme: initialize known effects to set ns_mgmt NCC and ns_attach NIC
Date: Wed, 22 Apr 2026 23:11:48 +0900 [thread overview]
Message-ID: <20260422141159.10881-3-ikegami.t@gmail.com> (raw)
In-Reply-To: <20260422141159.10881-1-ikegami.t@gmail.com>
This is to make sure scan_work done for the commands.
Since nvme_passthru_end called when effects set.
Also scan_work is flushed when NIC or NCC effects set.
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
---
drivers/nvme/host/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 1f973d88c830..1ed1fc866f3f 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3448,8 +3448,10 @@ static int nvme_init_effects_log(struct nvme_ctrl *ctrl,
static void nvme_init_known_nvm_effects(struct nvme_ctrl *ctrl)
{
- struct nvme_effects_log *log = ctrl->effects;
+ struct nvme_effects_log *log = ctrl->effects;
+ log->acs[nvme_admin_ns_mgmt] |= cpu_to_le32(NVME_CMD_EFFECTS_NCC);
+ log->acs[nvme_admin_ns_attach] |= cpu_to_le32(NVME_CMD_EFFECTS_NIC);
log->acs[nvme_admin_format_nvm] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC |
NVME_CMD_EFFECTS_NCC |
NVME_CMD_EFFECTS_CSE_MASK);
--
2.51.0
next prev parent reply other threads:[~2026-04-22 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 14:11 [PATCH v2 0/2] scan_work improvement Tokunori Ikegami
2026-04-22 14:11 ` [PATCH v2 1/2] nvme: delete unnecessary empty lines Tokunori Ikegami
2026-04-22 14:11 ` Tokunori Ikegami [this message]
2026-04-23 5:57 ` [PATCH v2 2/2] nvme: initialize known effects to set ns_mgmt NCC and ns_attach NIC Christoph Hellwig
2026-04-23 17:51 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422141159.10881-3-ikegami.t@gmail.com \
--to=ikegami.t@gmail.com \
--cc=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox