From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB3E4CD3436 for ; Thu, 7 May 2026 02:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Io/N+hHnLMI/zVIF68lkuWkyC9l4bvcPQWSmOV0m6oQ=; b=fvniX4EA/nMMaR4ckNIj5xod0c sQDZeByshCaqehYQ7G1xQ8QDyITwmKbvJg+GryLNMdD0lZfcVeTQfCD0ska+UkQEMHL7v9kN/Dfm+ OkKLlP1BsYDe1aostbnnFFVHSS673FVURgY4x+pOytRspHhtmJ93wPNOD6R/KPaQLeOyhVAZpIZ1p Es8EV1/s/GKroNqvsn+A2MzbnYY0FOi5M5s+zPtNOi0VN2XX9pbGNr2ZIeHyiVOro4L6hXDndQW10 IdneHNCV0ZM8AjDfRbIIZq1IstSltuyxwi56+24Y4dBS25TIlNC65DJpW2Sr4l2UuZPRHo5VP+p3M VymgchCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKoSe-00000002Wan-2cj5; Thu, 07 May 2026 02:27:36 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKd2W-000000012gZ-30vI for linux-nvme@lists.infradead.org; Wed, 06 May 2026 14:15:52 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4891cd5927dso8622845e9.0 for ; Wed, 06 May 2026 07:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778076949; x=1778681749; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Io/N+hHnLMI/zVIF68lkuWkyC9l4bvcPQWSmOV0m6oQ=; b=b7mfAnZakstYiU4aSVoFSdqhPtnLGAVdjsyGLlQ8zYpkBMofRNrGGxvlSbij/0R11a +O6Y4ZSHo7+vRJGTQ9a0DGUuTBl3GE3XWLab79sRDMRP98Ewj/CA+U51pjcaqZL5dSX6 KF91Qbw0JNwYwW7XupAKJwBPrVzdIe085hHqzGXmhuiANp0sJcIt7rw4OmhA7a4E7FmZ nBPGO9OUJgVOPYtZWfAqQfU0O/E1XfbFuZ8FDd3Qp06dfwh6gQg0pdNxnJ8HsPatrFFQ BO3WRUvGNu+/Pd6nK5nYqo1jXTe9/Ej/Qiar48pl9qnn4r4aZEiVe92msnICkMb1ZhBM SKIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778076949; x=1778681749; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Io/N+hHnLMI/zVIF68lkuWkyC9l4bvcPQWSmOV0m6oQ=; b=PXqjQVM/LeG+0lUjdhXIzssjgQbGGHQ8m0G6fLS69ioxvUuy7xOP+5/K79k4LPCJ21 HtjqswvOeAu6qLO5gn7AcfZZ8cH8n7ET1ImMVs9T6LaCywaHW4ziww6yZD7t0h8eGC3i kd4PKTJ1dUBS5T1/bDkl7WpnInjodxF3rhAZiT4r2qB3+kqHb4sbgMDe8zdLA3Szsjus wNANWYnF/LKJr/ikeJDViI/6noQDOcVRSVTMluDs89kQ2HzN2FbR6KYjLbyNFUdmt17G HvNqfjL13dTcHEC6mpzcEFb/9cJ2Vn5EyHlNakVHRJEXZUighR2zuDA5o0OPOUHP+iCK X2Mg== X-Forwarded-Encrypted: i=1; AFNElJ+q13Nw1am6i8hMd/6gqvyUSVbASGRwd2swnmgXQ9hfXIfzOZj1PbAEhf/Z9tcUfEa+NsMBzkpS01ba@lists.infradead.org X-Gm-Message-State: AOJu0Yzz8yD1egmaWWwIjLMXPyChihj190finoodKLLeidcILUcmI8dY jyl7Osh0WdWUsv3/3uktUVZlBetk9Px6r+NaQGk7kLVTEOhxi5GO4qQ= X-Gm-Gg: AeBDievlHO18NRq1QFWlp46OTF5Fo/yYfkzEz7X+o9oD2kUJTctKMqXTT7mLkDdhCkt pTxonfJloo9zB+70+0ER5LdiydNWVWJAYCn9p/r/Scsl2tzWvxSt7RSfGO9G5UMulZnrL1zOYnM GSE1t+TnAVD9bTklPJWosLDG+7NgWSbQTta632pP/FrPWS+XAy63xGC16m4Q5C+SwlXAKmZ2OvK uE/tN2+nnZ7fNSVjiAPiybEzsavj/B+JlbvJsqBLWigRO6ChfwrqMwftBQBB0bHzk3kjnOjpamf Be6UB6h51pkxSlI68s7IGvqMXogu5rrV4lgj64N0b2r9q6ITIUaXgN4qxHa9RHswkWUC+GW/MI6 0V0qfTVzFjsg50qs1UZ8JFpGFZrP6VUL9MfwCBHV1vQUiHtTMRbqxuKeSVqn5dUQa1j3BL9hfs4 PPdyjSl0ZYZmIQtTgtREfe6LanRbXnHcoAmjwGG06QFksm4W5o7Oww3Byl7wUckt5qeaGRbORj X-Received: by 2002:a05:600c:1f95:b0:486:fc61:541d with SMTP id 5b1f17b1804b1-48e51e124b9mr32527385e9.2.1778076948868; Wed, 06 May 2026 07:15:48 -0700 (PDT) Received: from localhost (8.red-80-39-165.dynamicip.rima-tde.net. [80.39.165.8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4505558e213sm13671647f8f.25.2026.05.06.07.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 07:15:47 -0700 (PDT) From: Xose Vazquez Perez To: Cc: Xose Vazquez Perez , Aviv Coro , Bart Van Assche , Benjamin Marzinski , Brian Bunker , Caleb Sander , Chaitanya Kulkarni , Chris Leech , Christophe Varoqui , Christoph Hellwig , Clayton Skaggs , Constantine Gavrilov , Daniel Wagner , =?UTF-8?q?David=20Santamar=C3=ADa=20Rogado?= , "Dmitry V. Levin" , "Ewan D. Milne" , Hannes Reinecke , James Smart , Jens Axboe , John Meneghini , Jyoti Rani , Keith Busch , Li Xiaokeng , Marco Patalano , Martin Belanger , Martin George , Martin Wilck , Matthias Rudolph , Maurizio Lombardi , NetApp RDAC team , Nilay Shroff , Randy Jennings , Sagi Grimberg , Simon Schricker , Steven Schremmer , Thomas Song , Uday Shankar , Vasuki Manikarnike , Wayne Berthiaume , Zou Ming , BLOCK-ML , DM_DEVEL-ML , NVME-ML , SCSI-ML Subject: [PATCH RFC] nvme-multipath: optimize path selection in queue-depth policy Date: Wed, 6 May 2026 16:15:41 +0200 Message-ID: <20260506141544.125089-1-xose.vazquez@gmail.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-Patchwork-Bot: notify Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260506_071552_782054_33095244 X-CRM114-Status: GOOD ( 14.75 ) X-Mailman-Approved-At: Wed, 06 May 2026 19:27:34 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Move the zero-depth check inside the optimized path case to enable early exit. It avoids redundant condition checks for non-optimized paths, and eliminates the per-iteration check at the end of the loop, improving the performance. Cc: Aviv Coro Cc: Bart Van Assche Cc: Benjamin Marzinski Cc: Brian Bunker Cc: Caleb Sander Cc: Chaitanya Kulkarni Cc: Chris Leech Cc: Christophe Varoqui Cc: Christoph Hellwig Cc: Clayton Skaggs Cc: Constantine Gavrilov Cc: Daniel Wagner Cc: David Santamaría Rogado Cc: Dmitry V. Levin Cc: Ewan D. Milne Cc: Ewan Milne Cc: Hannes Reinecke Cc: James Smart Cc: Jens Axboe Cc: John Meneghini Cc: Jyoti Rani Cc: Keith Busch Cc: Li Xiaokeng Cc: Marco Patalano Cc: Martin Belanger Cc: Martin George Cc: Martin Wilck Cc: Matthias Rudolph Cc: Maurizio Lombardi Cc: NetApp RDAC team Cc: Nilay Shroff Cc: Randy Jennings Cc: Sagi Grimberg Cc: Simon Schricker Cc: Steven Schremmer Cc: Thomas Song Cc: Uday Shankar Cc: Vasuki Manikarnike Cc: Wayne Berthiaume Cc: Zou Ming Cc: BLOCK-ML Cc: DM_DEVEL-ML Cc: NVME-ML Cc: SCSI-ML Signed-off-by: Xose Vazquez Perez --- Status: Compile-tested only. UNTESTED on real hardware. [I do not have access to this kind of hardware] Feedback and testing are highly welcome. --- drivers/nvme/host/multipath.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 263161cb8ac0..7d212f6e865d 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -409,6 +409,8 @@ static struct nvme_ns *nvme_queue_depth_path(struct nvme_ns_head *head) min_depth_opt = depth; best_opt = ns; } + if (min_depth_opt == 0) + goto out; break; case NVME_ANA_NONOPTIMIZED: if (depth < min_depth_nonopt) { @@ -419,11 +421,8 @@ static struct nvme_ns *nvme_queue_depth_path(struct nvme_ns_head *head) default: break; } - - if (min_depth_opt == 0) - return best_opt; } - +out: return best_opt ? best_opt : best_nonopt; } -- 2.54.0