From: Christoph Hellwig <hch@lst.de>
To: Geliang Tang <geliang@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Roy Shterman <roys@lightbitslabs.com>,
Solganik Alexander <sashas@lightbitslabs.com>,
Hannes Reinecke <hare@suse.de>,
Geliang Tang <tanggeliang@kylinos.cn>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvmet-tcp: fix page fragment cache leak in error path
Date: Wed, 27 May 2026 15:44:41 +0200 [thread overview]
Message-ID: <20260527134441.GA12536@lst.de> (raw)
In-Reply-To: <e4df8752611dc5914f849b1d17f5512434b954cb.1779787061.git.tanggeliang@kylinos.cn>
On Tue, May 26, 2026 at 05:22:22PM +0800, Geliang Tang wrote:
> out_ida_remove:
> ida_free(&nvmet_tcp_queue_ida, queue->idx);
> + /* Drain the page fragment cache if any allocations were done.
Kernel style is to keep the
/*
on it's own line, but otherwise this looks great. I think we can just
fix this up when applying.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-05-27 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 9:22 [PATCH v2] nvmet-tcp: fix page fragment cache leak in error path Geliang Tang
2026-05-27 13:44 ` Christoph Hellwig [this message]
2026-05-27 14:17 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527134441.GA12536@lst.de \
--to=hch@lst.de \
--cc=geliang@kernel.org \
--cc=hare@suse.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=roys@lightbitslabs.com \
--cc=sagi@grimberg.me \
--cc=sashas@lightbitslabs.com \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox