From: Christoph Hellwig <hch@lst.de>
To: guzebing <guzebing1612@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Guzebing <guzebing@bytedance.com>
Subject: Re: [PATCH v2] nvme: reduce firmware activation poll interval
Date: Tue, 14 Jul 2026 15:19:05 +0200 [thread overview]
Message-ID: <20260714131905.GB31615@lst.de> (raw)
In-Reply-To: <20260714092846.3381169-1-guzebing1612@gmail.com>
On Tue, Jul 14, 2026 at 05:28:46PM +0800, guzebing wrote:
> nvme_try_sched_reset(ctrl);
> return;
> }
> - msleep(100);
> + usleep_range(1000, 2000);
Add a comment that this matches nvme_wait_ready? Or even better add
a helper with a name like nvme_busy_wait and add a comment describing
the use case?
prev parent reply other threads:[~2026-07-14 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:28 [PATCH v2] nvme: reduce firmware activation poll interval guzebing
2026-07-14 13:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714131905.GB31615@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=guzebing1612@gmail.com \
--cc=guzebing@bytedance.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox