From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Chao Shi <coshi036@gmail.com>,
kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, axboe@kernel.dk,
joshi.k@samsung.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH v2] nvme: skip the zoned limits update if the zone info query failed
Date: Mon, 17 Aug 2026 08:53:52 +0200 [thread overview]
Message-ID: <20260817065352.GA16255@lst.de> (raw)
In-Reply-To: <9d0e59fc-392d-425c-bc9a-ee3d1510f95b@kernel.org>
On Mon, Aug 17, 2026 at 03:17:22PM +0900, Damien Le Moal wrote:
> On 8/17/26 04:17, Chao Shi wrote:
> > nvme_query_zone_info() returns either a negative errno or a positive
> > NVMe status code, but nvme_update_ns_info_block() only tests for the
>
> That seems like a bad design of nvme_query_zone_info(). Why not fix it so that
> on error it returns either negative values OR NVMe status code? That would
> avoid the pitfall of the error check that you found.
Because in some case the difference matters, and this thus is a common
pattern in the nvme driver.
next prev parent reply other threads:[~2026-08-17 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 19:17 [PATCH v2] nvme: skip the zoned limits update if the zone info query failed Chao Shi
2026-08-17 6:17 ` Damien Le Moal
2026-08-17 6:53 ` Christoph Hellwig [this message]
2026-08-17 6:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817065352.GA16255@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=coshi036@gmail.com \
--cc=dlemoal@kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=weizhu@fiu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox