From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
John Garry <john.garry@linux.dev>
Subject: Re: [PATCH RFC v2 1/2] block: scan partitions for hidden disks
Date: Wed, 19 Aug 2026 11:00:50 +0200 [thread overview]
Message-ID: <20260819090050.GA9267@lst.de> (raw)
In-Reply-To: <20260818120854.3151628-2-john.g.garry@oracle.com>
On Tue, Aug 18, 2026 at 12:08:53PM +0000, John Garry wrote:
> From: John Garry <john.garry@linux.dev>
>
> If a disk is hidden (GENHD_FL_HIDDEN flags set), we currently do not scan
> the disk partition table.
>
> GENHD_FL_HIDDEN is used in NVMe multipath support to hide the per-path
> disk.
It also is used for giving a handle to NVMe devices that we can't support
as block devices and for which we only want a handle to issue passthrough
commands. For those attempting a partition scan is rather suboptimal.
As is in general doing an extra scan per controller when we know it must
give the same results. Wouldn't it make more sense to just propagate
the partition table from the ns_head to each individual path?
next prev parent reply other threads:[~2026-08-19 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 12:08 [PATCH RFC v2 0/2] fix NVMe multipath partition diskstats John Garry
2026-08-18 12:08 ` [PATCH RFC v2 1/2] block: scan partitions for hidden disks John Garry
2026-08-19 9:00 ` Christoph Hellwig [this message]
2026-08-19 9:12 ` John Garry
2026-08-19 9:13 ` Christoph Hellwig
2026-08-19 9:43 ` John Garry
2026-08-18 12:08 ` [PATCH RFC v2 2/2] nvme-multipath: fix diskstats for partitions John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819090050.GA9267@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=john.garry@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox