From: Jakub Kicinski <kuba@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Geliang Tang <geliang@kernel.org>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Stanislav Fomichev <sdf@fomichev.me>,
Geliang Tang <tanggeliang@kylinos.cn>,
linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
mptcp@lists.linux.dev, Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH v4 1/4] nvmet-tcp: unify sockopt with do_sock_setsockopt
Date: Thu, 20 Aug 2026 10:31:09 -0700 [thread overview]
Message-ID: <20260820103109.4d8ed110@kernel.org> (raw)
In-Reply-To: <20260819090439.GB9267@lst.de>
On Wed, 19 Aug 2026 11:04:39 +0200 Christoph Hellwig wrote:
> > A key benefit of this refactoring is that it decouples the socket option
> > configuration from the underlying transport protocol. This makes it
> > easier to extend nvmet-tcp to support other protocols, such as MPTCP, in
> > the future, as do_sock_setsockopt() abstracts away protocol-specific
> > differences without requiring per-option protocol-specific wrappers.
>
> We really should have generic helpers in the networking code for this
> and not duplicate them in driver using socket options.
What do you mean by "for this" ?
next prev parent reply other threads:[~2026-08-20 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 6:02 [PATCH v4 0/4] nvme-tcp: add IPv6 traffic class support Geliang Tang
2026-08-18 6:03 ` [PATCH v4 1/4] nvmet-tcp: unify sockopt with do_sock_setsockopt Geliang Tang
2026-08-18 8:30 ` Hannes Reinecke
2026-08-19 9:04 ` Christoph Hellwig
2026-08-19 11:04 ` Breno Leitao
2026-08-19 13:23 ` Breno Leitao
2026-08-20 17:31 ` Jakub Kicinski [this message]
2026-08-18 6:03 ` [PATCH v4 2/4] nvme-tcp: " Geliang Tang
2026-08-18 6:03 ` [PATCH v4 3/4] nvmet-tcp: support IPv6 traffic class Geliang Tang
2026-08-18 6:03 ` [PATCH v4 4/4] nvme-tcp: " Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820103109.4d8ed110@kernel.org \
--to=kuba@kernel.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=leitao@debian.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
--cc=sdf@fomichev.me \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox