From: Mohamed Khalfella <mkhalfella@purestorage.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Surabhi Gogte <sgogte@purestorage.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
randyj@purestorage.com, adailey@purestorage.com
Subject: Re: [PATCH v2 2/2] nvme-tcp: parallelize I/O queue allocation and startup
Date: Sun, 30 Aug 2026 15:59:39 -0700 [thread overview]
Message-ID: <20260830225939.GC1842415-mkhalfella@purestorage.com> (raw)
In-Reply-To: <4f2d2b60-56f9-4ae3-b38f-bba9754011df@grimberg.me>
On Mon 2026-08-31 01:44:32 +0300, Sagi Grimberg wrote:
>
>
> On 31/08/2026 1:25, Mohamed Khalfella wrote:
> > On Mon 2026-08-31 01:00:52 +0300, Sagi Grimberg wrote:
> >>
> >> On 25/08/2026 1:56, Surabhi Gogte wrote:
> >>> - ret = sock_create_kern(current->nsproxy->net_ns,
> >>> + ret = sock_create_kern(&init_net,
> >> I don't think we can just change this...
> > Why we can not change it? Today the error recovery code running in
> > worker thread will be using init_net anyway, no?
> See commit: 1be52169c3488ef98582ed553ab35cefa3978817
Thanks for the pointer. I was not aware of that. What about error
recovery case? I _think_ it will be using init_net, no?
Also, Will the change to sock_create_kern(&init_net) break the fix in
commit 1be52169c348 ("nvme-tcp: fix selinux denied when calling
sock_sendmsg")?
next prev parent reply other threads:[~2026-08-30 22:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 22:56 [PATCH v2 0/2] nvme-tcp: parallelize I/O queue connect Surabhi Gogte
2026-08-24 22:56 ` [PATCH v2 1/2] nvme-tcp: refactor I/O queue setup path Surabhi Gogte
2026-08-30 21:56 ` Sagi Grimberg
2026-09-02 21:25 ` Surabhi Gogte (she/her)
2026-08-24 22:56 ` [PATCH v2 2/2] nvme-tcp: parallelize I/O queue allocation and startup Surabhi Gogte
2026-08-24 23:58 ` Randy Jennings
2026-08-30 22:00 ` Sagi Grimberg
2026-08-30 22:25 ` Mohamed Khalfella
2026-08-30 22:44 ` Sagi Grimberg
2026-08-30 22:59 ` Mohamed Khalfella [this message]
2026-09-04 16:04 ` Surabhi Gogte (she/her)
2026-09-05 22:29 ` Sagi Grimberg
2026-09-04 16:05 ` Surabhi Gogte (she/her)
2026-09-05 22:30 ` Sagi Grimberg
2026-09-10 20:32 ` Surabhi Gogte (she/her)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260830225939.GC1842415-mkhalfella@purestorage.com \
--to=mkhalfella@purestorage.com \
--cc=adailey@purestorage.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
--cc=sgogte@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox