From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4CDBC79FB7 for ; Thu, 10 Sep 2026 05:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kM1asefRzlTMQqkTKP71SwQrpojMzoGiIXcpMzpP52k=; b=jTxomGTfHx5L9xMYaC7iMLBA2i BJN4Pf8I/lUZ5rpGYS5qGmIVYBjqlhdx5kJiefVXIqdV7e9lRPci7GzoZsHZ8rlrpqHSNjt98O1/v mgstXsf48SzId29bPaxlUNLL6j9+bsfTCwY+1gXwtBnvGPTuXdDYyz7EDBwaZIfyAtcLzH0JqUnjB aTeVJrcUh7O7qeL6UG+j6FBJv1eTKZzARBwOGh/sQQlPf/9ycTgHEieqo4tTXVmdkSZr+Q48jqZK1 HvrrI1KTKAZG2fAoPBGVxoA7OEg+QMufK14nTBXtJPKXOkdX0RBH/diU4ZCCo1APRs0hORGJCSqnE xHqSPm1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4XIa-0000000DRB6-0sMG; Thu, 10 Sep 2026 05:26:12 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4XIW-0000000DRAA-0m40 for linux-nvme@lists.infradead.org; Thu, 10 Sep 2026 05:26:11 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4A70368BFE; Thu, 10 Sep 2026 07:26:04 +0200 (CEST) Date: Thu, 10 Sep 2026 07:26:04 +0200 From: Christoph Hellwig To: Runyu Xiao Cc: Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andreas Hindborg , Breno Leitao , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jianhao Xu Subject: Re: [PATCH v3 2/3] nvmet: avoid recursive configfs open for file-backed namespaces Message-ID: <20260910052604.GC27133@lst.de> References: <20260902103202.GB8095@lst.de> <20260910045400.1201582-1-runyu.xiao@seu.edu.cn> <20260910045400.1201582-3-runyu.xiao@seu.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260910045400.1201582-3-runyu.xiao@seu.edu.cn> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260909_222610_323619_6F783BF9 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Sep 10, 2026 at 12:53:59PM +0800, Runyu Xiao wrote: > + ret = kern_path(ns->device_path, LOOKUP_FOLLOW, &path); > + if (ret) { > + pr_err("failed to open file %s: (%d)\n", > + ns->device_path, ret); > + return ret; > + } > + > + if (configfs_path_is_configfs(&path)) { > + pr_err("configfs paths cannot back namespace %s\n", > + ns->device_path); > + path_put(&path); > + return -EINVAL; > + } > + > + ns->file = file_open_root(&path, "", flags, 0); Can we please still have this in the helper?